OrigamiEngine icon indicating copy to clipboard operation
OrigamiEngine copied to clipboard
verified publisher icon ap4y

Adds HTTPHeaders for playing from http source

Open igorkravchenko opened this issue 11 years ago • 5 comments

Sometimes it is required to send HTTP headers along with URL. Is there a chance we can add this?

igorkravchenko avatar Dec 08 '14 09:12 igorkravchenko

:+1: this would be amazing.

mmcdole avatar Jan 30 '15 03:01 mmcdole

I often have to play mp3s from sources that require oauth authorization headers.  This would help me out a lot. The changes made my @igorkravchenko looks pretty clean. Would love to have it in master.

sadhiappan avatar Jan 30 '15 03:01 sadhiappan

For some reason I missed this PR, I think I was on vacation around that time :) Will merge in next couple days.

ap4y avatar Jan 30 '15 23:01 ap4y

Still on vacation? ;)

igorkravchenko avatar Jun 22 '15 09:06 igorkravchenko

Sorry for not responding previously. I didn't merge this PR because I didn't like idea of having plugin specific options on engine mediator (plus some code styling issues). I tried to draft different implementation, but got sidetracked as always. Right now I'm not too interested in investing much time into new features, as described here. If someone needs this feature, I think it should be ok to use your branch or fork and patch.

ap4y avatar Jun 22 '15 23:06 ap4y