Andreas Poehlmann

Results 343 comments of Andreas Poehlmann

Thanks, nicely done. But as you said, this won't work with the STS. I'll have a look into this soon and then merge it.

You could do the following: implement a **list_unopened_spectrometers()** function in **utils.py**, which (as you suggested) creates a dict of all available spectrometers, but catches and ignores the **USBError** if a...

> When using the the dark current correction it is possible that the datasheets are wrong about which pixels can be used, at least that was the case for the...

Hi Simon, @mzieg is working on a fix for this. The dark pixel indices have to be double checked for each individual detector model. (Exactly like you did.) Until then...

While your implementation of the nonlinearity correction is correct, you **must not** apply this correction to a spectrum that was not dark-count-corrected! So before this can be merged into master,...

_"Do you mean that the a dark spectrum has to be substracted before the nonlinearity correction ?"_ No. The counts of the **dark pixels** (the ones that are physically blocked...

Will be resolved when PR #19 gets merged.

Hi @barneygale, I finally found some time to start moving `universal_pathlib` to `PathBase`. To make some of the type checks pass, I wrote type stubs for parts of `pathlib_abc`. If...

This sounds very interesting for `universal_pathlib`. Cross-referencing fsspec/universal_pathlib#145 In `filesystem_spec` this "non `os.stat_result` returning" method is provided by [`AbstractFileSystem.info()`](https://github.com/fsspec/filesystem_spec/blob/303a0858dd9e3aea131b9e2274d22150d6d4f30e/fsspec/spec.py#L640-L656) and its return value is a dictionary with a few standardised...

> Out of interest, why not a dataclass rather than a dict with standardised keys? I was leaning towards a dataclass personally. Subclasses (e.g. `S3Status`) could add their own fields....