OpenJPH
OpenJPH copied to clipboard
clang-cl creates false positive for compiler options
It seems
https://github.com/aous72/OpenJPH/blob/edc3210f7c9640a76b9d6150cfad48bb157f4549/CMakeLists.txt#L135-L141
presumes that these options are valid. But with clang-cl (Clang's MSVC equivalent), these compiler options will be passed to clang-cl which are then invalid (specifically -Wextra).
CMAKE_CXX_COMPILER_ID is still reported as Clang, not clang-cl, so I assume the fix could be
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU" AND NOT MSVC)