OpenJPH icon indicating copy to clipboard operation
OpenJPH copied to clipboard

clang-cl creates false positive for compiler options

Open clshortfuse opened this issue 3 weeks ago • 1 comments

It seems

https://github.com/aous72/OpenJPH/blob/edc3210f7c9640a76b9d6150cfad48bb157f4549/CMakeLists.txt#L135-L141

presumes that these options are valid. But with clang-cl (Clang's MSVC equivalent), these compiler options will be passed to clang-cl which are then invalid (specifically -Wextra).

CMAKE_CXX_COMPILER_ID is still reported as Clang, not clang-cl, so I assume the fix could be

if (CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU" AND NOT MSVC)

clshortfuse avatar Dec 16 '25 16:12 clshortfuse