eslint-plugin-spellcheck icon indicating copy to clipboard operation
eslint-plugin-spellcheck copied to clipboard

Keep color codes

Open smallstepstoday opened this issue 4 years ago • 1 comments

Retain hash for color codes embedded in strings or tagged template literals. Currently these hash symbols are being stripped out incorrectly making it impossible to know that a word is in fact a color code.

smallstepstoday avatar Jul 12 '20 18:07 smallstepstoday

Would love to see this merged.

gajus avatar Oct 12 '21 05:10 gajus

Could this same funcionality be done by configuration using skipIfMatch paramater for the config? and adding the regexp there?

Let me check it out

aotaduy avatar Dec 01 '22 12:12 aotaduy

My change simply adds a check for valid color codes and does not change the application logic or configuration parameters. I think it is the least impact change. Everything else in the library seems to work just fine

smallstepstoday avatar Dec 02 '22 03:12 smallstepstoday

Yes, I saw your changes but i think we can do the same with a configuration parameter and without changing the code. I will always prefer the configuration solution over changes in the code. I will try to check this on these days. Thanks!

aotaduy avatar Dec 02 '22 12:12 aotaduy