nonrec-make icon indicating copy to clipboard operation
nonrec-make copied to clipboard

Produce an error if SRCS contains an invalid path.

Open KholdStare opened this issue 10 years ago • 2 comments

Hi Andrzej,

Previously, all wrong entries in SRCS would be silently filtered out. This change aims to keep Rules.mk files accurate, and easier to debug.

Thanks!

KholdStare avatar May 02 '14 04:05 KholdStare

Hello Alex

I would like to merge your changes however there is one thing that bothers me. What if the source which one gives to SRCS is being generated from some other file - like lex.c from lex.l or grammar.c from grammar.y. I haven't checked but it seems that your solution will raise an error before generating rules while we should be giving make chance to figure out how to produce it.

Maybe instead of raising an error we should be passing source unchanged or automatically replacing .c/.cpp into .o and letting make to signal an error.

Best regards Andrzej

aostruszka avatar May 05 '14 09:05 aostruszka

Hi Andrzej

Yes, you are right! I'll think about it, and see if it is possible to delay the check till the target is built.

Perhaps using = for lazy evaluation instead of := could help?

Regards, Alex.

KholdStare avatar May 05 '14 14:05 KholdStare