Error and strange behavior of the application when using an incorrect password

[Oleg-Chashko]

Configuration

• Keka version: 1.2.8 (4395) Beta
• macOS version: 11.1 (20C69)

Describe the bug

1. Create a zip archive with a random password and always with the "Use AES-256 encryption" function enabled.

Archive example:

Frame Diagram.pdf.zip

2. Trying to open the archive by typing a lot of "space key", I only use it.

https://user-images.githubusercontent.com/62497891/104630242-d72dfe00-569a-11eb-8373-ee38cc11236d.mov

3. An error occurs.

Error log:

Log.rtf.zip

---

The second option for the end of the torment :)

3. Keka unpacks the archive with an incorrect password. Unpacks files with zero volume.

https://user-images.githubusercontent.com/62497891/104631267-4eb05d00-569c-11eb-8c13-b39676075d72.mov

4. A window appears with a choice of further action.

---

P.S.: After my mockery of KEKA :) Something in her soul broke :(( Now, after unpacking, it always shows a window. I have not changed the settings!

[aonez]

I’ll look the password thing later, the close issue is because that build has some unfinished code 😅

On Thu, 14 Jan 2021 at 19:24 Oleg Chashko [email protected] wrote:

Assigned #758 https://github.com/aonez/Keka/issues/758 to @aonez https://github.com/aonez.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/aonez/Keka/issues/758#event-4207594315, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADVHIZAERZ5MJ3EG7MZWZ3SZ4ZHNANCNFSM4WC2YNVQ .

[Oleg-Chashko]

I’ll look the password thing later, the close issue is because that build has some unfinished code 😅 …

Keka version: 1.2.7 (4394) Release, exactly the same behavior.

OS: Version 11.1 (Build 20C69)
Keka: v1.2.7-r4394 (WEB) (Sandboxed) (en-GB)
Format detected: ZIP (7Z)
Binary used: keka7z
Arguments: (
    x,
    "/Users/elena_chashko/Desktop/Frame Diagram.pdf.zip",
    "-o/Users/elena_chashko/Desktop/Frame Diagram.pdf.kextraction/Operation",
    "-aou",
    "-xr!__MACOSX"
)

7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21
p7zip Version 16.02 (locale=utf8,Utf16=on,HugeFiles=on,64 bits,4 CPUs x64)
Modified by aONe for Keka

Scanning the drive for archives:
  0M Scan /Users/elena_chashko/Desktop/

1 file, 11939909 bytes (12 MiB)

Extracting archive: /Users/elena_chashko/Desktop/Frame Diagram.pdf.zip
--
Path = /Users/elena_chashko/Desktop/Frame Diagram.pdf.zip
Type = zip
Physical Size = 11939909

  0%


___KEKA___PASSWORD___KEKA___
ERROR: Wrong password : Frame Diagram.pdf

OS: Version 11.1 (Build 20C69)
Keka: v1.2.7-r4394 (WEB) (Sandboxed) (en-GB)
Format detected: ZIP (7Z)
Binary used: keka7z
Arguments: (
    x,
    "/Users/elena_chashko/Desktop/Frame Diagram.pdf.zip",
    "-o/Users/elena_chashko/Desktop/Frame Diagram.pdf.kextraction/Operation",
    "-aou",
    "-xr!__MACOSX"
)

7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21
p7zip Version 16.02 (locale=utf8,Utf16=on,HugeFiles=on,64 bits,4 CPUs x64)
Modified by aONe for Keka

Scanning the drive for archives:
  0M Scan /Users/elena_chashko/Desktop/

1 file, 11939909 bytes (12 MiB)

Extracting archive: /Users/elena_chashko/Desktop/Frame Diagram.pdf.zip

--
Path = /Users/elena_chashko/Desktop/Frame Diagram.pdf.zip
Type = zip
Physical Size = 11939909

  0%

___KEKA___PASSWORD___KEKA___

ERROR: Wrong password : Frame Diagram.pdf

OS: Version 11.1 (Build 20C69)
Keka: v1.2.7-r4394 (WEB) (Sandboxed) (en-GB)
Format detected: ZIP (7Z)
Binary used: keka7z
Arguments: (
    x,
    "/Users/elena_chashko/Desktop/Frame Diagram.pdf.zip",
    "-o/Users/elena_chashko/Desktop/Frame Diagram.pdf.kextraction/Operation",
    "-aou",
    "-xr!__MACOSX"
)

7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21
p7zip Version 16.02 (locale=utf8,Utf16=on,HugeFiles=on,64 bits,4 CPUs x64)
Modified by aONe for Keka

Scanning the drive for archives:
  0M Scan /Users/elena_chashko/Desktop/

1 file, 11939909 bytes (12 MiB)

Extracting archive: /Users/elena_chashko/Desktop/Frame Diagram.pdf.zip
--
Path = /Users/elena_chashko/Desktop/Frame Diagram.pdf.zip
Type = zip
Physical Size = 11939909

  0%

___KEKA___PASSWORD___KEKA___

ERROR: Wrong password
 : Frame Diagram.pdf

Error code 2

[aonez]

@Oleg-Chashko I can't reproduce your issue with the password, are you still able to reproduce it with v1.2.9?

It should fail with 10-20 working tries, depending on the format. This is an explicit limitation I've added, 10 tries for binary extraction. With some ZIPs you'll get 10 times using UNAR and 10 with P7ZIP, so 20 total.

Maybe I'll get rid of this limitation, because for brute force there're better alternatives to use than Keka.

[aonez]

1. Keka unpacks the archive with an incorrect password. Unpacks files with zero volume.

Be sure to enable "Remove bad password header structure extractions" in Keka -> Preferences -> Extraction. Should be enabled by default and remove those blank structure files. Although I don't get why it did not show any error in that video...

[Oleg-Chashko]

@Oleg-Chashko I can't reproduce your issue with the password, are you still able to reproduce it with v1.2.9?

It should fail with 10-20 working tries, depending on the format.

OS: Version 11.1 (Build 20C69)
Keka: v1.2.9-r4434 (WEB) (Sandboxed) (en)
Format detected: ZIP (7Z)
Binary used: keka7z
Arguments: (
    x,
    "/Users/elena_chashko/Desktop/Frame.Diagram.pdf.zip",
    "-o/Users/elena_chashko/Desktop/Frame.Diagram.pdf.kextraction/Operation",
    "-aou",
    "-xr!__MACOSX"
)

7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21
p7zip Version 16.02 (locale=utf8,Utf16=on,HugeFiles=on,64 bits,4 CPUs x64)
Modified by aONe for Keka

Scanning the drive for archives:
  0M Scan /Users/elena_chashko/Desktop/

1 file, 11939909 bytes (12 MiB)

Extracting archive: /Users/elena_chashko/Desktop/Frame.Diagram.pdf.zip

--
Path = /Users/elena_chashko/Desktop/Frame.Diagram.pdf.zip
Type = zip
Physical Size = 11939909

  0%

___KEKA___PASSWORD___KEKA___

ERROR: Wrong password
Error code 2

[Oleg-Chashko]

1. Keka unpacks the archive with an incorrect password. Unpacks files with zero volume.

Be sure to enable "Remove bad password header structure extractions" in Keka -> Preferences -> Extraction. Should be enabled by default and remove those blank structure files. Although I don't get why it did not show any error in that video...

This item is always included in Keka!

[Oleg-Chashko]

Keka.log

[aonez]

Error code 334

This is the expected error when reaching the maximum number of retries. So is It sometimes failing before and sometimes working as expected for you?

[Oleg-Chashko]

1. Keka unpacks the archive with an incorrect password. Unpacks files with zero volume.

Be sure to enable "Remove bad password header structure extractions" in Keka -> Preferences -> Extraction. Should be enabled by default and remove those blank structure files. Although I don't get why it did not show any error in that video...

This item is always included in Keka!

Zero file problem in v.1.9.0

[Oleg-Chashko]

Error code 334

This is the expected error when reaching the maximum number of retries. So is It sometimes failing before and sometimes working as expected for you?

@aonez Sorry, but I didn't understand what you wanted to say. English is not my mother tongue. (So is It sometimes failing before and sometimes working as expected for you?)

[Oleg-Chashko]

@Oleg-Chashko I can't reproduce your issue with the password, are you still able to reproduce it with v1.2.9?

It should fail with 10-20 working tries, depending on the format. This is an explicit limitation I've added, 10 tries for binary extraction. With some ZIPs you'll get 10 times using UNAR and 10 with P7ZIP, so 20 total.

Maybe I'll get rid of this limitation, because for brute force there're better alternatives to use than Keka.

Now I understand the meaning! (So is It sometimes failing before and sometimes working as expected for you?)

I didn't count how many times.

[Oleg-Chashko]

You have to enter the wrong password 19 times.

Example as I would like:

[aonez]

OK so you are suggesting to remove the "Error code 334 using "binary" part and leave it as "Bad password, try again", right?

[Oleg-Chashko]

OK so you are suggesting to remove the "Error code 334 using "binary" part and leave it as "Bad password, try again", right?

Yes. The mistake of many programmers is that they think that at least programmers work with the program and forget about ordinary people who are the majority. Imagine that you are an ordinary person. You will understand this: "Error code 334 using" binary "? :)