Keka icon indicating copy to clipboard operation
Keka copied to clipboard

Finder Extension shows incorrect external volume sidebar icons

Open shuuiran opened this issue 4 years ago • 20 comments

Workaround

This seems to be a bug in macOS. As a workaround you can disable the external volume integration of Keka's context menu in the Preferences. Available in Keka v1.2.3 and later. Still not fixed in macOS 12 Monterey, as reported by @kapitainsky in #938.

Possible extra information about this issue 👉 https://github.com/knurling/ServiceStation/issues/51

Screen Shot 2021-11-01 at 12 51 34

Workaround for folders (not external volumes)

👉 Take a look at this comment: https://github.com/aonez/Keka/issues/667#issuecomment-983514749


Original issue

Configuration

  • Keka version: 1.2.2 (4199)
  • macOS version: 11.0.1 (20B29)

Describe the bug

在macOS Big Sur 11.0.1 (20B29), 在打开了Keka的Finder扩展的情况下,Finder里外接磁盘的图标显示会不正确。 in macOS Big Sur 11.0.1 (20B29), If the Keka extension is enabled, the external hard drives icon is incorrect in Finder

Screenshots

截屏2020-11-17 下午3 05 12

shuuiran avatar Nov 17 '20 07:11 shuuiran

Thanks @zhouweiluan!

aonez avatar Nov 17 '20 10:11 aonez

This is an Apple bug. Workaround is here: https://github.com/knurling/ServiceStation/issues/40#issuecomment-653660235

gingerbeardman avatar Nov 17 '20 10:11 gingerbeardman

So seems that this should be fixed by Apple then... I can meanwhile add an option to disable external disk monitoring, ~so the Finder Extension will only be present at external disks that where mounted when the extension started~.

The problem appears when the external volume is assigned in the Finder Extension directoryURLs, I thought it was about NSWorkspaceDidMountNotification and such.

aonez avatar Nov 17 '20 10:11 aonez

This build has the option to disable the external volumes integration: Keka-appx-volumes.7z

I've tested and this fixes the issue although renders the context menu useless outside the OS drive 😞

Hopefully Apple can fix this soon.

aonez avatar Nov 17 '20 13:11 aonez

Version 1.2.3 is released now with the option to workaround this issue.

aonez avatar Nov 20 '20 08:11 aonez

Where did you get the information about "Big Sur 11.0.1 and earlier"?

I am reproducing this issue on Big Sur 11.1 Beta (20C5048l) on a DTK. I don't yet have access to a non-beta install.

I opened a ticket for it in my Finder Sync Extension here: https://github.com/knurling/ServiceStation/issues/51

pkamb avatar Nov 21 '20 22:11 pkamb

I meant 11.0 and 11.0.1... Haven't had the change to try 11.1 beta yet. Just changed the descriptions there's no confusion. I've already posted in your previous issue https://github.com/knurling/ServiceStation/issues/40#issuecomment-728856509. Will be creating a feedback ticket for  pointing this issue and yours.

Sadly this error reminds me of https://github.com/aonez/Keka/issues/453, an error introduced in Catalina that was fixed in Big Sur... Hopefully they fix this one in Big Sur and not in macOS 12.0 or whatever they call the new one.

aonez avatar Nov 22 '20 09:11 aonez

@aonez I also see the same problem with Keka v1.2.9 (4434) on Catalina 10.15.7: when "Show in external volumes" or the Finder extension is enabled, disks other than the boot one are shown as a generic folder icon.

Screen Shot 2021-02-03 at 07 44 15

lfom avatar Feb 03 '21 10:02 lfom

@lfom please read earlier comments

gingerbeardman avatar Feb 03 '21 13:02 gingerbeardman

@lfom just disable external volumes in Keka - Preferences - Finder extension as stated in the main topic of this issue. Thanks!

aonez avatar Feb 03 '21 13:02 aonez

Yeah, I know the workaround (as I wrote in my previous comment). I just wanted to report that it also happens in Catalina, and also in Mojave by the way, so it is not specific to BS.

lfom avatar Feb 03 '21 13:02 lfom

Ah thanks @lfom! I did found this in Catalina but did not tested Mojave.

aonez avatar Feb 03 '21 14:02 aonez

I can confirm it happens in Mojave.

gingerbeardman avatar Feb 03 '21 15:02 gingerbeardman

Still happen on Big Sur 11.4 (Mac pro 2020 M1)

Apolsus avatar Jul 01 '21 12:07 Apolsus

Confirmed this happens on Big Sur and corrected it by turning off external volumes in settings.

J-Wick4 avatar Nov 07 '21 07:11 J-Wick4

1adf06a6-e79e-4ae5-9f64-0da6a05e6cd0-1 I wonder how does Dropbox workaround this issue...

lexrus avatar Nov 12 '21 01:11 lexrus

@lexrus Dropbox add an icon to its folder, as I remember. Keka does not add any icon to any folder but macOS renders bad icons to external drives.

aonez avatar Nov 12 '21 15:11 aonez

On my system the bug also occurs for the normal monitored folder visible in the sidebar.

sbarex avatar Nov 29 '21 11:11 sbarex

@sbarex this will affect all directories (folders or volumes), other than this ones (from Apple's doc):

NOTE The sidebar icons you provide will replace the default folder icons in the Finder’s sidebar for any of the root folders that your extension is monitoring. This icon does not replace the icon for any folders contained by your monitored folder. It also does not replace the icon for any system folders that you may be monitoring (for example, Documents, Desktop, Applications, and Downloads).

So you can simply add parent folder to the Finder Extension list instead of the folder you're adding to the sidebar.

An example:

  • Adding /Users/sbarex/Documents/MySidebarFolder to the sidebar
  • Adding /Users/sbarex/Documents/MySidebarFolder to Keka's Finder Extension list
  • MySidebarFolder has a bad icon

Workaround:

  • Adding /Users/sbarex/Documents/MySidebarFolder to the sidebar
  • Adding /Users/sbarex/Documents to Keka's Finder Extension list
  • MySidebarFolder has the correct icon

aonez avatar Dec 01 '21 10:12 aonez