aonez
No warnings while decompressing partially corrupted archive
So just started using keka and I love the simplicity of it but ran into an issue. I downloaded an archive from google photos, two zip softwares failed to extract that archive because it's corrupted, but when I extract it with keka it partially extracts the archive without any warnings. In this case I knew in advance that the zip is damaged but this could be a huge problem if the user does not know that the archive is damaged and only a few of the files have been able to be extracted.
While extracting with 7zip on my mac os cli, it extracts all files damaged and the good ones but I also see the following errors which is good:
ERRORS:
Headers Error
WARNINGS:
Headers Error
--
Path = Photos (1).zip
Type = zip
ERRORS:
Headers Error
WARNINGS:
Headers Error
Physical Size = 7763711449
64-bit = +
Characteristics = Zip64 Unsorted_CD
am i missing some options for extractions in settings?
Originally posted by @ihamzapped in https://github.com/aonez/Keka/discussions/1643
Seconded. This behavior has bitten me twice when I've downloaded ZIP files from Slack. My designer periodically sends over ZIP files with a large number of product images for upload to the website. Since Slack doesn't indicate when the file has been completely downloaded and Keka silently unzips the partially unzipped file, I've uploaded incomplete batches of image that's resulted in many broken links. We couldn't figure out what was wrong until it happened again just now. Please add a setting to enable warning notifications if there's a problem with the ZIP file. Please and thank you!
Not sure how I missed this issue, sorry @ihamzapped. Can you or @LunarRed send a test file that reproduces this issue?
@aonez I tried to redownload my ZIP file from Slack and paused the download before it completed, thinking that I could send you the partially downloaded file; however, when I tried to unzip it using Keka, it now throws a fatal error with a notification:
I thought I was going crazy so I tried to recreate the silent partial decompression again. It turns out, for at least my situation, I only get the silent partial unzipping when I unzip with Keka WHILE the file is still downloading from Slack. There are supposed to be 21 SKUs (represented as subdirectories) in this ZIP file. As you can see below, when I extract using Keka before the download finishes, only 13 SKUs/subdirectories extract, and I don't get a notification.
My guess is that the file still needs to be open by Slack (or another program) to reproduce?
If it is a header issue as @ihamzapped pointed in the original issue then the file is properly downloaded but badly created. @LunarRed can you download one of those previous files that had the issue maybe you can reproduce with them?