ember-cli-chart icon indicating copy to clipboard operation
ember-cli-chart copied to clipboard

Published 20 hours ago • verified publisher icon aomran

Update to ChartJS 3.5

Open walter opened this issue 3 years ago • 4 comments

Closes #127

Supersedes PR #136

See previous PR for background, but basically only updates ChartJS rather than also trying to sort out the chart-chartjs-financial dependency. That will be dealt with in a separate PR.

walter avatar Oct 11 '21 01:10 walter

@aomran if this PR looks good would you be able to merge it? The project I am working on would really benefit from the new APIs available in [email protected]

raheed-web avatar Feb 17 '22 16:02 raheed-web

@aomran We would need this one as well, could this get merged?

nanderss avatar Mar 18 '22 16:03 nanderss

@aomran Could this get merged?

TonnyBiDa avatar May 11 '22 23:05 TonnyBiDa

@aomran :)

ntnz avatar Jun 16 '22 02:06 ntnz

Is there any hope that this PR will merge?

ixxvivxxi avatar Nov 01 '22 21:11 ixxvivxxi

LGTM!

RobbieTheWagner avatar Feb 15 '23 13:02 RobbieTheWagner

Does anyone know if there are breaking changes in Chart.js that we need to address in this addon? Test coverage seems light and just does assert.dom('canvas').exists(); so unsure if this breaks anything.

RobbieTheWagner avatar Feb 15 '23 14:02 RobbieTheWagner

One thing that I disliked about Chart 2 was that it required a global moment to be available. Since version 3 that is not needed anymore; you can now drop in an available time library as an adapter.

Not sure if that affects ember-cli-chart / its tests. More info about the changes is on https://www.chartjs.org/docs/latest/migration/v3-migration.html#setup-and-installation.

Frank3K avatar Feb 15 '23 14:02 Frank3K

Since this has not been released how can I have this update available in my repo?

heshamnimri avatar Apr 25 '23 16:04 heshamnimri