wallet-standard icon indicating copy to clipboard operation
wallet-standard copied to clipboard

Published 20 hours ago • verified publisher icon anza-xyz

remove warning for bs58 5.0.0

Open beeman opened this issue 1 year ago • 5 comments

When installing @solana/wallet-adapter-react, this message appears when you have the latest version of bs58 installed.

warning "@solana/wallet-adapter-react > @solana/wallet-standard-wallet-adapter-react > @solana/[email protected]" has incorrect peer dependency "bs58@^4.0.1".

This patch widens the dependency range.

beeman avatar Oct 10 '23 18:10 beeman

Friendly ping, would be great if this could be merged! 🙌

beeman avatar Jan 13 '24 22:01 beeman

Looks good! Can you add a patch changeset?

jordaaash avatar Jan 16 '24 20:01 jordaaash

Hmm actually, I need to think about this change and see how we're using the dependency. bs58 5 breakingly changes from Buffer to Uint8Array types.

jordaaash avatar Jan 16 '24 20:01 jordaaash

This affect us as well, the warning show up every time we install/change dependencies. I can report that we've been using this package with [email protected] without any issues for the past months.

gcangussu avatar Apr 17 '24 21:04 gcangussu

This affect us as well, the warning show up every time we install/change dependencies. I can report that we've been using this package with [email protected] without any issues for the past months.

Same, zero issues since the moment I created this PR.

I think we're safe here 😄

beeman avatar Apr 18 '24 05:04 beeman