wallet-adapter
wallet-adapter copied to clipboard
WalletConnect wallets do not generally support versioned transaction
Describe the bug
The PR to introduce versioned transaction support #777, introduces a UX bug for 99% of WalletConnect users. dApps are no longer able to read the supportedTransactionVersions
field to reliably drop into a "legacy" transaction mode. This leads to a broken flow as users are left to find and manually toggle, when available, that setting.
To Reproduce Take a wallet implementing WalletConnect but not Ottr
- Go to jup.ag
- Pick a swap, click swap
- It breaks in many flavours, depending on the wallet. For https://github.com/WalletConnect/web-examples/tree/main/wallets/react-wallet-v2 it breaks down in the wallet and the approve button throws an error while never returning anything to jup.ag
Expected behavior Providing the appropriate supportedTransactionVersions given the underlying wallet. Can this be a dynamic feature check on the remote wallet?
supportedTransactionVersions
should at least be reverted until the dust settles with supporting a potential proper interface to sign transaction #806
cc @jnwng
Who's in charge of the WalletConnect solana spec? May I suggest having it mirror the wallet-standard solana features as closely as possible in the future?
idea: The wallets implement the CAIP-25 standard. As such they can signal to the dapp in the CAIP-25 response whether they support supportedTransactionVersions
. Possibly it can also signal the value for this.
Hi, wondering if this will be released so that some wallet can handle versioned transaction 🙏