wallet-adapter icon indicating copy to clipboard operation
wallet-adapter copied to clipboard

WalletConnect wallets do not generally support versioned transaction

Open Arrowana opened this issue 1 year ago • 4 comments

Describe the bug The PR to introduce versioned transaction support #777, introduces a UX bug for 99% of WalletConnect users. dApps are no longer able to read the supportedTransactionVersions field to reliably drop into a "legacy" transaction mode. This leads to a broken flow as users are left to find and manually toggle, when available, that setting.

To Reproduce Take a wallet implementing WalletConnect but not Ottr

  1. Go to jup.ag
  2. Pick a swap, click swap
  3. It breaks in many flavours, depending on the wallet. For https://github.com/WalletConnect/web-examples/tree/main/wallets/react-wallet-v2 it breaks down in the wallet and the approve button throws an error while never returning anything to jup.ag

Expected behavior Providing the appropriate supportedTransactionVersions given the underlying wallet. Can this be a dynamic feature check on the remote wallet?

supportedTransactionVersions should at least be reverted until the dust settles with supporting a potential proper interface to sign transaction #806

Arrowana avatar Jul 16 '23 22:07 Arrowana

cc @jnwng

jordaaash avatar Jul 31 '23 18:07 jordaaash

Who's in charge of the WalletConnect solana spec? May I suggest having it mirror the wallet-standard solana features as closely as possible in the future?

billythedummy avatar Aug 11 '23 06:08 billythedummy

idea: The wallets implement the CAIP-25 standard. As such they can signal to the dapp in the CAIP-25 response whether they support supportedTransactionVersions. Possibly it can also signal the value for this.

arein avatar Dec 19 '23 12:12 arein

Hi, wondering if this will be released so that some wallet can handle versioned transaction 🙏

williamliangwl avatar Jun 07 '24 10:06 williamliangwl