wallet-adapter icon indicating copy to clipboard operation
wallet-adapter copied to clipboard

Published 20 hours ago • verified publisher icon anza-xyz

Adding ability to signMessage with Ledger adapter

Open martincik opened this issue 2 years ago • 14 comments

For this patch to work, we would need a new Solana App released with supporting off-chain message signing. The code is done here: https://github.com/LedgerHQ/app-solana/pull/37 not yet been released.

martincik avatar Jan 25 '23 15:01 martincik

🦋 Changeset detected

Latest commit: 3d846748112b816611bf201785b1286a684094fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@solana/wallet-adapter-ledger Patch
@solana/wallet-adapter-wallets Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jan 25 '23 15:01 changeset-bot[bot]

@elbywan any possibility of getting the new Solana app released with the off-chain signing?Thank you.

martincik avatar Jan 25 '23 15:01 martincik

Hey @martincik, sorry but I am not working in the Ledger firmware team and my work is not related to the nano apps at all.

elbywan avatar Jan 25 '23 21:01 elbywan

@jordansexton Thanks for the review and feedback. I've applied all the input and reverted all the new derivative path codes. Feel free to let me know if there's anything else I can do to move it forward.

martincik avatar Feb 18 '23 22:02 martincik

This looks good. I think we need to wait to merge until the Ledger app actually supports the full message preamble: https://edge.docs.solana.com/proposals/off-chain-message-signing#message-preamble

The current (1.3.1) release does support INS_SIGN_MESSAGE_OFFCHAIN and Phantom has done some testing, which (I'm told) works: https://github.com/phantom-labs/sandbox/pull/33/files#diff-ef62378fde56dd1b353bf1263bff96352f72df5be1d8c676855450bdf42cd61f

But the addition to the Ledger app was done before the spec was finalized, and some of the message headers have changed.

jordaaash avatar Feb 22 '23 19:02 jordaaash

pinging you on this @jordansexton, when do you expect to merge this?

manzgoeggel avatar Mar 08 '23 16:03 manzgoeggel

hey @jordansexton , are there any plans to merge this anytime soon?

tiboprea avatar Mar 10 '23 10:03 tiboprea

This is still in development for the Ledger app. While the app was updated to include message signing support, it doesn't implement the final version of the Solana offline signing spec yet. Apps shouldn't start to use until it's implemented correctly (the message preamble has changed, so the input and signatures won't match). I'll merge this when it's released.

jordaaash avatar Mar 20 '23 21:03 jordaaash

so ledger is still working on this I assume?

manzgoeggel avatar Jun 07 '23 15:06 manzgoeggel

This is still in development for the Ledger app. While the app was updated to include message signing support, it doesn't implement the final version of the Solana offline signing spec yet. Apps shouldn't start to use until it's implemented correctly (the message preamble has changed, so the input and signatures won't match). I'll merge this when it's released.

hey jordan was there any update on this?

danvernon avatar Oct 12 '23 16:10 danvernon

Hey any update on this?

Dulb26 avatar Apr 18 '24 21:04 Dulb26