wallet-adapter
wallet-adapter copied to clipboard
anza-xyz
Add Infinity Wallet adapter
This PR adds the wallet adapter for the Infinity Wallet, allowing our users to easily connect to Solana DApps via our unique Infinity Wallet Browser-less Web3 feature (removing the need to use a browser-extension wallet) on desktop. Solana is supported in the Infinity Wallet from v2.0.0 and higher.
Hello, we are following up to see if there is anything else needed to add the Infinity Wallet Connector to the library. We are currently waiting on integration into the library for partnerships to proceed with integration.
I also want to draw your attention to https://github.com/wallet-standard/wallet-standard
It's still WIP, so while I'll continue to merge adapter PRs for the next few weeks, we are quickly moving in the direction of no longer needing adapters for wallets that implement the standard.
@jordansexton Thanks for your feedback, we have made the requested changes that are possible to change.
Renaming to Infinity would be incorrect however as InfinityWallet is our name. Also regarding the openInfinityWallet function inside get url(), this is a necessary workaround for our unique implementation to allow for opening the DApp in the standalone Infinity Wallet app via deeplink when clicking from outside of the wallet.
Also regarding the openInfinityWallet function inside get url(), this is a necessary workaround for our unique implementation to allow for opening the DApp in the standalone Infinity Wallet app via deeplink when clicking from outside of the wallet.
We won't accept or publish a wallet adapter that does this. You may consider self-publishing your own adapter if you think it's a make or break feature, but it won't be included in the @solana/wallet-adapter-wallets package for the reasons given.
Please don't mark review comments as resolved when there have not been changes to the code in question.
Also regarding the openInfinityWallet function inside get url(), this is a necessary workaround for our unique implementation to allow for opening the DApp in the standalone Infinity Wallet app via deeplink when clicking from outside of the wallet.
We won't accept or publish a wallet adapter that does this. You may consider self-publishing your own adapter if you think it's a make or break feature, but it won't be included in the
@solana/wallet-adapter-walletspackage for the reasons given.
It is unfortunate that you are against supporting innovation with our new type of wallet/browser, we can remove this part of the adapter however the user experience will be heavily impacted. Regarding the resolved comments, everything was changed other than the name as mentioned above, as that would have been incorrect.
Hi @jordansexton, please review the complete changes for the integration and the comments. Thanks
Thanks for your PR. I won't be accepting it at this time because all requested changes have not been made and it's already taken up too much time in repeated reviews.
Additionally, we will no longer be accepting PRs for wallet adapters for browser extension wallets in this repo. If you want to, consider self-publishing your package on npm.
However, with support for Mobile Wallet Adapter and the Wallet Standard being added to Wallet Adapter, please instead check out the reference implementations of wallets implementing the Wallet Standard here:
https://github.com/wallet-standard/wallet-standard/tree/master/packages/wallets
InfinityWallet can implement the Wallet Standard similarly in a completely permissionless way to work with dapps, which doesn't require dapps to use a wallet adapter for InfinityWallet, or any other wallet implementing the standard.