anytype-ts icon indicating copy to clipboard operation
anytype-ts copied to clipboard

The edit buttons of the embedded block may block some use of embedded content

Open LavaCxx opened this issue 1 year ago • 2 comments

Have you read a contributing guide?

  • [X] I have read CONTRIBUTING.md
  • [X] I have searched the existing issues and didn't find any that were similar
  • [X] I have considered creating a pull request with fixes instead of a bug report and want to proceed

Current Behavior

image

Expected Behavior

Perhaps it would be better to have the edit buttons automatically hidden at the edge, only displays the full part when hovering.

Steps To Reproduce

None

Environment

None

Anything else?

No response

LavaCxx avatar Jan 17 '24 14:01 LavaCxx

Hello @LavaCxx! It's Alex from Anytype design team.

Let's check if I got you right. Do you suggest to show the icon on the right, outside of the embed container? We're discussing having some controls on the right side of a block. However, this have to be done systematically, so we can re-use this mechanics later. We will discuss it further within the team and try to implement sooner. Thank you for your suggestion!

Cheers, Alex

sebyakin avatar Jan 18 '24 11:01 sebyakin

Hello @LavaCxx! It's Alex from Anytype design team.

Let's check if I got you right. Do you suggest to show the icon on the right, outside of the embed container? We're discussing having some controls on the right side of a block. However, this have to be done systematically, so we can re-use this mechanics later. We will discuss it further within the team and try to implement sooner. Thank you for your suggestion!

Cheers, Alex

It cannot be outside, because in a full-width situation it may cause buttons to appear in invisible places. I recommend using a design similar to the floating balls on phones, which does not necessarily need to be movable, as long as it takes up very little space when not hovered.

https://github.com/anyproto/anytype-ts/assets/48022591/28bfcef5-a2b4-4eeb-a2a2-d3d605807223

LavaCxx avatar Jan 18 '24 12:01 LavaCxx