orval icon indicating copy to clipboard operation
orval copied to clipboard

orval/core - generating factory method for schema interfaces

Open mironbalcerzak opened this issue 1 year ago • 9 comments

Status

WIP

Description

Fix https://github.com/anymaniax/orval/issues/1331

This PR is providing simple implementation. Opening for discussion. Bugs? Possible - definitely "stackoverflow" in case of self referencing or cycle

Todos

  • [ ] Tests
  • [ ] Documentation
  • [ ] Changelog Entry (unreleased)

mironbalcerzak avatar Apr 27 '24 19:04 mironbalcerzak

Hi, @mironbalcerzak I'll review it. Let me know when you change the status to Ready.

soartec-lab avatar Apr 30 '24 14:04 soartec-lab

@soartec-lab - ive been using this branch in few projects of mine over last months - seems ok. How can we progress so it ends in "master"?

mironbalcerzak avatar Sep 22 '24 10:09 mironbalcerzak

It looks like the tests are failing?

melloware avatar Sep 22 '24 11:09 melloware

@melloware, yeah, i am aware and that will be fixed shortly - i meant on a broader scale - should i implement/change something in PR?

mironbalcerzak avatar Sep 22 '24 11:09 mironbalcerzak

i think once its fixed and passing we will re-review.

melloware avatar Sep 22 '24 11:09 melloware

@mironbalcerzak Thank you for mada good enhance. I'll review this !

soartec-lab avatar Sep 23 '24 00:09 soartec-lab