wayvnc icon indicating copy to clipboard operation
wayvnc copied to clipboard
verified publisher icon any1

main: Added quit on last client disconnect

Open cybin opened this issue 1 year ago • 4 comments

I needed an option to automatically quit wayvnc when the last client disconnect.

Added a condition in client_destroy() and set self->server->do_exit to true, if condition is met.

For example, if wayvnc will only run intentionally by starting via SSH, it automatically quit when I close the VNC connection and no other clients are connected.

cybin avatar May 21 '24 12:05 cybin

Hi, have you read CONTRIBUTING.md?

any1 avatar May 21 '24 12:05 any1

Hi, have you read CONTRIBUTING.md?

Yes, I did. But obviously not to the very last line.

cybin avatar May 21 '24 14:05 cybin

Thanks for your help.

So, I'm going to rename everything to exit-on-disconnect and change 'q' to 'e' accordingly. Will push later today, when I got the time to test it.

cybin avatar Jun 03 '24 14:06 cybin

LGTM. Please squash into single commit. Keep in mind that commit messages should be written in imperative mood. A commit message should complete the sentence "When applied, this patch will...".

I.e. "main: Added quit on last client disconnect" might be written "main: Add option to exit on last disconnect" instead.

any1 avatar Jun 08 '24 12:06 any1

Pulled

any1 avatar Aug 16 '25 21:08 any1