plugin.video.youtube icon indicating copy to clipboard operation
plugin.video.youtube copied to clipboard

Codec: add opus support

Open tiagogaspar8 opened this issue 3 years ago • 4 comments

Hi!

I wanted to ask for support for the opus audio codec instead of the current aac. It's open source so it's a better alternative to fit with the current VP9 coded.

I've read also that it might have better audio quality (?).

Thanks!

tiagogaspar8 avatar Jan 25 '22 18:01 tiagogaspar8

This isn't currently possible, as inputstream.adaptive doesn't support opus currently. It will be added to the add-on when possible though.

anxdpanic avatar Jan 25 '22 18:01 anxdpanic

Ok, should I keen this open?

On another side not, I'm confused about the differences between YouTube and tubed, is there any literature on it?

Thanks for the quick response!

tiagogaspar8 avatar Jan 25 '22 18:01 tiagogaspar8

As a test, I edited the resources\lib\youtube_plugin\kodion\impl\xbmc\xbmc_context.py file and changed 'opus': None in capability_map to 'opus': '2.3.14' and it played with opus audio with no issue

2022-01-25 16:03:43.030 T:11504 DEBUG <general>: [plugin.video.youtube] Generated MPD highest supported quality found: |{'video': {'height': '2160', 'fps': '30000/1001', 'codec': 'vp9', 'mime': 'video/webm', 'quality_label': '2160p', 'bandwidth': 11800658}, 'audio': {'bitrate': 160, 'codec': 'opus', 'mime': 'audio/webm', 'bandwidth': 133899}}| 2022-01-25 16:03:43.871 T:11800 INFO <general>: CDVDAudioCodecFFmpeg::Open() Successful opened audio decoder opus

yeahme49 avatar Jan 25 '22 22:01 yeahme49

I must have missed when this changed, thanks for the heads up. Will look at adding it.

anxdpanic avatar Jan 25 '22 22:01 anxdpanic

fixed by https://github.com/anxdpanic/plugin.video.youtube/pull/379

bkuhls avatar Dec 23 '22 19:12 bkuhls