plugin.video.twitch icon indicating copy to clipboard operation
plugin.video.twitch copied to clipboard

Adaptive HLS

Open anxdpanic opened this issue 7 years ago • 24 comments

anxdpanic avatar Apr 26 '17 11:04 anxdpanic

this might be related to multithreaded segments download.. as a feature to also help against buffering

untoreh avatar Apr 27 '17 15:04 untoreh

Both of these will rely on Kodi, or a binary add-on in the future to provide that functionality. With the progression with dash/mpd support it does look promising, just not available for hls yet.

anxdpanic avatar Apr 27 '17 15:04 anxdpanic

inputstream.adaptive support added in #326 requires latest script.module.python.twitch master https://github.com/MrSprigster/Twitch-on-Kodi/releases/tag/2.1.0-alpha

anxdpanic avatar Sep 28 '17 19:09 anxdpanic

Is it possible to integrate the Time Shift function similar to the YouTube Addon?

greystashh avatar Oct 30 '17 23:10 greystashh

I don't believe time shift will be possible

anxdpanic avatar Nov 09 '17 13:11 anxdpanic

Have you tried to?

greystashh avatar Nov 18 '17 18:11 greystashh

Looking at this more currently, and trying to capture log of a few issues as well. Offending streams and my availability have been what's slowed that progess. Hoping to catch them tonight.

anxdpanic avatar Nov 18 '17 18:11 anxdpanic

Have you been successful?

greystashh avatar Nov 25 '17 15:11 greystashh

Have provided peak3d with logs for streams with issues(don't play(non-win)/crash(win)).

Still not looking like time shift will be available, but will keep an eye on it. After we bump to release with adaptive working, I will close this issue and open a new timeshift one.

anxdpanic avatar Nov 25 '17 15:11 anxdpanic

Do you think that timeshift is not possible because of inputstream hls or is it twitch related issue?

greystashh avatar Dec 06 '17 14:12 greystashh

At the core it's twitch, there is no way to request a specific segment in live content that I can see. Likely due to the way they shift live content to their separate vod system. May be some(within played time/cache) support for it later when appending segments is possible in inputstream, though I believe that is still quite a ways out.

anxdpanic avatar Dec 06 '17 15:12 anxdpanic

Has there been any news so far?

greystashh avatar Jan 01 '18 21:01 greystashh

Have you already been able to fix some issues?

greystashh avatar Jan 06 '18 09:01 greystashh

Been no movement, I don't expect timeshift to be anytime soon if at all. It's something I would like to see as well, will be keeping an eye on it. I have noticed that some streams that previously didn't load with adaptive were working which may be due to a few different things.

anxdpanic avatar Jan 06 '18 13:01 anxdpanic

Do you know the reason why some streams still dont work with adaptive?

greystashh avatar Jan 14 '18 16:01 greystashh

No, I collected a bunch of the stream metadata(codecs, node, cluster etc.) and there are working examples that match not working examples, and theres no way to tell if player stopped due to error to failover automatically. So setting a default quality for the not working streams is the only way around that.

anxdpanic avatar Jan 14 '18 16:01 anxdpanic

Might it be possible to deactivate adaptive for Vods as a temporary workaround to avoid activate and deactivate inputstream manually?

greystashh avatar Jan 14 '18 16:01 greystashh

Yea, I also may change the behaviour and make adaptive available to qualities still but only used if it's set as default manually. Seems too often they are not working, and I'd like to get this version to official so I can start work on migrating to helix api.

anxdpanic avatar Jan 14 '18 17:01 anxdpanic

#351 Changes it so adaptive is no longer default if enabled.

anxdpanic avatar Jan 14 '18 18:01 anxdpanic

Updated https://github.com/MrSprigster/Twitch-on-Kodi/releases/tag/2.1.0-alpha with the change, will test for a couple days then go to official.

anxdpanic avatar Jan 14 '18 23:01 anxdpanic

Could you cancel the change again? With new inputstream versions I havent experienced much errors anymore. Besides it is not very comfortable to select it manually. In general playback without adaptive is laggy. If a video wouldnt play with adaptive you can easily turn inputstream off. I think that is the better solution than now

greystashh avatar Mar 21 '18 16:03 greystashh

I didn't revert the change, but you can now choose Adaptive as a default quality. https://github.com/MrSprigster/Twitch-on-Kodi/releases/tag/2.2.1-test

anxdpanic avatar Mar 21 '18 21:03 anxdpanic

@greystashh can you confirm this working for you as well. Next update is expected to be a larger python 3 compat. update, so I will bump this minor if this resolves it. Thank you 👍

anxdpanic avatar Mar 22 '18 17:03 anxdpanic

Yes, it works now

It would be nice if you can bump it to official repo

greystashh avatar Mar 23 '18 01:03 greystashh