cddl icon indicating copy to clipboard operation
cddl copied to clipboard

Fix AST parsing for comments

Open SebastienGllmt opened this issue 2 years ago • 1 comments

Presumably due to a copy-paste mistake, the condition on this flag was the opposite of what it should be.

You can see this function has 3 cases where it looks at compiler flags. The 3rd flag correctly uses not(feature = "lsp"), but the first flag doesn't.

SebastienGllmt avatar Aug 19 '22 06:08 SebastienGllmt

Seems the CI fails because of error: package "clap v3.2.17" cannot be built because it requires rustc 1.56.1 or newer, while the currently active rustc version is 1.56.0 which is unrelated to this PR

Seems the fix to that CI issue is included as part of https://github.com/anweiss/cddl/pull/121

SebastienGllmt avatar Aug 26 '22 18:08 SebastienGllmt

Thanks for this @SebastienGllmt. #121 has been merged. Feel free to rebase.

anweiss avatar Sep 12 '22 15:09 anweiss

seems there is a new version-related failure in the CI :/

package os_str_bytes v6.3.0 cannot be built because it requires rustc 1.57.0 or newer, while the currently active rustc version is 1.56.1

SebastienGllmt avatar Sep 12 '22 16:09 SebastienGllmt

Yep. Just bumped the MSRV to 1.57.0 in https://github.com/anweiss/cddl/commit/2464beafb5bbec2ee83fe0303bd5830cd3613759. Try rebasing again.

anweiss avatar Sep 12 '22 16:09 anweiss