hugo-embed-pdf-shortcode icon indicating copy to clipboard operation
hugo-embed-pdf-shortcode copied to clipboard

Install as a Theme Component

Open RoneoOrg opened this issue 1 year ago • 2 comments

Installation and updates would be easier with a Theme Component. I just did a successful installation this way and I can provide a PR. But before tackling this I would like to know if this PR has any chance to get merged. What do you think anvitks, is it the right way to go?

RoneoOrg avatar Jul 31 '22 07:07 RoneoOrg

@RoneoOrg thank you for reaching out. Yes, this seems like a good way to install or include the shortcode. Unfortunately I do not have experience of installing the shortcode this way. If you can share the link to a plugin that is installed this way or if you can raise the PR then we can definitely explore the option of this method of installation.

anvithks avatar Aug 01 '22 13:08 anvithks

Hi @anvithks ,

If you can share the link to a plugin that is installed this way or if you can raise the PR then we can definitely explore the option of this method of installation.

~~I made a first draft in this branch: https://github.com/RoneoOrg/hugo-shortcode-roneo-embed-pdf/tree/theme-component~~ Update: see this PR instead

Feel free to test and criticize as much as you want.
I did some other tweaks BTW, may some bits interest someone

Cheers

RoneoOrg avatar Aug 16 '22 19:08 RoneoOrg