anvilvapre

Results 86 comments of anvilvapre

Perhaps clarify the exception message so that in future people understand the cause and can find the solution themselves. i.e. refer them to comp zip application.

I'm fine with closing this. At the time i was trying to understand how the rebuilding of the grids worked and came across it. It's perhaps too trivial to spend...

Likely not related to the Rendering of the shroud. In a past pull request i mentioned that Shroud.IsVisible and IsExplored 'contradict' each other. If shroud is enabled and if fog...

Please don't recalculate game statistics that only change each logic tick at 60+ frames per second. Like currently is done. Split up the calculation/model and rendering. This will make specs...

In the world of web they use the term `debounce` - where they limit the number of events to x per ms.

https://github.com/rix0rrr/beacon/blob/eeb5e3b6dccfba57b1a21ce29ce85ef1378b817f/BeaconLib/Probe.cs#L103-L107

Here it doesn't. Results in full removal and addition. https://github.com/OpenRA/OpenRA/blob/c63be297701eeb79334f5fe1068de2efcc212bca/OpenRA.Mods.Common/Traits/AffectsShroud.cs#L132-L133

OpenRA.Mods.Cnc/SpriteLoaders/ShpTDLoader.cs ``` else if (h.Format == Format.XORLCW && !offsets.TryGetValue(h.RefOffset, out h.RefImage)) throw new InvalidDataException($"Reference doesn't point to image data {h.FileOffset}->{h.RefOffset}"); } ```

i believe there is also a matching issue for this. perhaps you can try to link it. i.e. resolves \#issueid.