anvilvapre

Results 86 comments of anvilvapre

I suspect the issue is near https://github.com/OpenRA/OpenRA/blob/7fe2af99fbccb28b25f70f0948d3eb67788b33b2/OpenRA.Mods.Common/Widgets/Logic/Ingame/WorldTooltipLogic.cs#L167 but i do not see yet how this PR introduced it. The only place the Y of the extra label is updated if...

> I suspect the issue is near > > https://github.com/OpenRA/OpenRA/blob/7fe2af99fbccb28b25f70f0948d3eb67788b33b2/OpenRA.Mods.Common/Widgets/Logic/Ingame/WorldTooltipLogic.cs#L167 > > but i do not see yet how this PR introduced it. > The only place the Y of...

Solved an additional issue. When opening the map selector dialog an exception occurred. As worldRenderer was missing as widget load argument.

> Solved an additional issue. When opening the map selector dialog an exception occurred. As worldRenderer was missing as widget load argument. Which occurs in all places when OpenWindow is...

The improvement may not be visually noticable. It saves ~12 million vertices being copied per game tick minute, ~0.2 million per second. Each vertex being 13 floats in size, 416...

> This might come in conflict with the shader rework i did. Especialy as there are some key thing regarding how shaders and vertex buffers work which might totaly change...

> How much does it spend afterwards? I did this count in `SwapData` after I made the change. So this is the actual saving. So this is only the data...

> > The game spends 0.6% of all CPU time - across all threads - in `SpriteRenderer.Flush()` and underlying methods before this change. > > I meant this. It started...

> The idea here seems reasonable, but I think it is a bad idea to call the new method `SwapData`. Calling `VertexBuffer.SwapData` in particular feels misleading, suggesting that the value...