connect icon indicating copy to clipboard operation
connect copied to clipboard

Published 20 hours ago • verified publisher icon anvilresearch

/signout endpoint unhandled exception

Open amokrushin opened this issue 8 years ago • 2 comments

Error: Can't set headers after they are sent. ... at /srv/nodejs/oidc/node_modules/anvil-connect/oidc/signout.js:53:13 ...

How to reproduce: send signout request with post redirect uri and valid token

https://github.com/anvilresearch/connect/blob/a21dd1ff17d4893bb97eb7beb455888afb10eea0/oidc/signout.js#L53-L67

In that case both res.sendStatus(204) and res.redirect(303, postLogoutUri) will be called in the same request and will cause the error

The test passed because there is a mistake: 62b538b08c0a48321763b9b69123d9d676bbded9

amokrushin avatar Sep 11 '16 22:09 amokrushin

#352 PR fix this issue !

camfou avatar Oct 16 '16 13:10 camfou

Thanks @camfou! Just merged #352.

@amokrushin, please let me know if this solves your issue.

Sorry everyone for neglecting this repo recently. I've been a little distracted from working with the good people at CSAIL on OIDC for https://solid.mit.edu/

New packages in the works that should eventually find their way back into Anvil Connect :) Ping me on gitter if anyone wants a preview. We could use the extra eyes.

christiansmith avatar Oct 16 '16 23:10 christiansmith