Anuar Ustayev (aka Anu)
Anuar Ustayev (aka Anu)
Hi @zelima hope you're doing great! 😄 It would be great if you could move this dataset from your own account to this org? https://github.com/zelima/big-mac-index
Here is another fix for this - https://github.com/datopian/data.js/commit/db55e8cbe45aea30e564325f84a3035df8a151c9 which uses file extension to detect file format. I'm not sure if using mimetype is a good idea.
@kmanaseryan Please, feel free to close this issue as fixed if you believe so.
@kmanaseryan yes and we're actually using that lib already https://github.com/datopian/data.js/blob/master/package.json#L53 and https://github.com/datopian/data.js/blob/b03836de6b3291173d2c37901456ba5f5aeb2baf/src/index.js#L369 I'm not sure about that lib because it might be just mapping file extension to mime-type.
@rufuspollock this is one of the reasons for data explorer's size. cc/ @starsinmypockets
`xlsx` seems huge as it has both **reader** and **writer** for xlsx/xls. I guess we need only xlsx/xls **reader** so we could replace it with, e.g., `xlsx-extractor` which is 4x...
@starsinmypockets I think implementing lazy loading would make sense in data explorer but not in data.js.
@rufuspollock we started doing this to support different field delimiters such as semicolon etc.
@rufuspollock I might be wrong but as I know in some countries, e.g., France and Italy `;` is used more frequently than `,` as a field delimiter. I've also seen...
@leondz I'm glad to see this issue 👍🏼 I was wondering if we could use https://portaljs.org/ here and we're willing to contribute here.