Anurudh Peduri
Anurudh Peduri
this was completed in #1451 and #1456
I think this refers to #1078
Requires some fixes to how shapes and num_qubits are computed to work with symbolics, and updated type hints. Didn't want to over-complicate #1155, so this can be done in a...
@fpapa250 this will be fixed by #1492 (which removes the call graph override and uses the default from `ControlledViaAnd`). I tested the code snippet against that branch and it prints...
> Would specifying a dtype for OnEach solve the problem? Yep I think so, by updating the signature. and passing the dtype to the `split` in the decomp. https://github.com/quantumlib/Qualtran/blob/157459ef8c267b18d3a7f79fe4bd5d7653a21636/qualtran/bloqs/basic_gates/on_each.py#L63-L69 But...
> TODO: can these be And? Yep you can use CZPow = And^dagger . ZPow . And
There are bloqs which use `And` in compute-uncompute pairs, which then fails with the cirq simulator (even state vector). I think some old `GateWithRegisters` code return a `cirq.ControlledGate` in some...
this should be resolved now as #1456 reduces multiple controls to a single control
Hi @dobbse42! Here is some feedback on the PR, hope it is helpful! > Do we want to perform input validation (e.g. ancillasize < bitsize-1)? If so, what is the...
Hi! I'd like to contribute to this.