SwapReads icon indicating copy to clipboard operation
SwapReads copied to clipboard

Feat: Subscribe to newsletter must be just above the footer and in the center of web page, taking 100% of width

Open divyalaldinani opened this issue 1 year ago • 6 comments
trafficstars

Describe the feature

now: image

should be like this: image

Add ScreenShots

added above

Record

  • [X] I agree to follow this project's Code of Conduct
  • [X] I'm a GSSOC'24 contributor
  • [X] I want to work on this issue

divyalaldinani avatar May 18 '24 17:05 divyalaldinani

Describe the feature

now: image

should be like this: image

Add ScreenShots

added above

Record

  • [X] I agree to follow this project's Code of Conduct
  • [X] I'm a GSSOC'24 contributor
  • [X] I want to work on this issue

but then we have to redesign the footer cause there is a lot of empty space

huamanraj avatar May 18 '24 18:05 huamanraj

Describe the feature

now: image should be like this: image

Add ScreenShots

added above

Record

  • [x] I agree to follow this project's Code of Conduct
  • [x] I'm a GSSOC'24 contributor
  • [x] I want to work on this issue

but then we have to redesign the footer cause there is a lot of empty space

yeah, you are right, check out the footer of this https://www.deeplearning.ai/

if you want, i can change it to something like this

divyalaldinani avatar May 18 '24 18:05 divyalaldinani

hey @huamanraj let me know, if i should start working on it..

divyalaldinani avatar May 20 '24 07:05 divyalaldinani

hey @huamanraj let me know, if i should start working on it..

great 👍 yup work on it! and take care of website theme! @divyalaldinani

and ping me for any help you need. i am the mentor of this project!

huamanraj avatar May 20 '24 07:05 huamanraj

@divyalaldinani

Assigned!

Make sure to attach before & after screenshots in your PR. Also, star the repo before working on it. While creating your PR, ensure you pull all existing changes beforehand to avoid conflicts.

Happy open-source contributing!

anuragverma108 avatar May 23 '24 18:05 anuragverma108

@huamanraj @anuragverma108 it looks like this now image

should i make changes to footer also? like adjusting the sm icons ?

divyalaldinani avatar May 26 '24 11:05 divyalaldinani

@anuragverma108 hey can you check it once?

@huamanraj @anuragverma108 it looks like this now image

should i make changes to footer also? like adjusting the sm icons ?

divyalaldinani avatar May 30 '24 11:05 divyalaldinani

@huamanraj @anuragverma108 can you check it once?

divyalaldinani avatar Jun 03 '24 13:06 divyalaldinani

@huamanraj @anuragverma108 can you check it once?

sorry for the late response because there are a lot of issues and PRs in repo and thanks for showing the patience and understanding you can go with this and create a PR on the latest codebase! i am the project mentor so reach out to me for any help needed! @divyalaldinani

huamanraj avatar Jun 03 '24 13:06 huamanraj

Hello @divyalaldinani! Your issue #654 has been closed. Thank you for your contribution!

github-actions[bot] avatar Jun 06 '24 16:06 github-actions[bot]