anuraghazra
Progress bar background color
Is your feature request related to a problem? Please describe.
I want to use the top-langs badge with the transparent theme, but I can't find an option to set the progress bar background color.
Describe the solution you'd like
I would like an additional option to set the background color to make the badge look like in this image (edited with GIMP):
The additional option could be called prog_bg_color, so my example would be something like: https://github-readme-stats.vercel.app/api/top-langs/?username=Le0X8&size_weight=0.5&count_weight=0.5&langs_count=8&theme=transparent&border_radius=0&hide_border=true&title_color=108c92&text_color=0c686c&prog_bg_color=222222.
Describe alternatives you've considered
No response
Additional context
No response
I have enhanced the code by adding the prog_bg_color feature. Please review the pull request and consider merging it if it meets your requirements. If it doesn't, please provide feedback or state the reasons for not merging it.
My Pr : - https://github.com/anuraghazra/github-readme-stats/pull/3312
could you please assign this task to me? i would love to solve this issue @anuraghazra
Hey @anuraghazra , pleasure to meet you! I created a new pr, would be happy if you could check and approve it if it meets your requirements. If you have anything related to React, Javascript, Typescript or Python, feel free to hit me up! Thanks in advance!
I have enhanced the code by adding the
prog_bg_colorfeature. Please review the pull request and consider merging it if it meets your requirements. If it doesn't, please provide feedback or state the reasons for not merging it.My Pr : - #3312
@a-s-t-e-y-a I left my review, check it out https://github.com/anuraghazra/github-readme-stats/pull/3312#pullrequestreview-1672274828
@rickstaa i think that guy is hasn't contributed for last 4 days so can uh pass on this task to me
@qwerty541 can I do this task
Hey, @airwakz! Thanks for your interest in our project! We already have a pull request which will solve this issue https://github.com/anuraghazra/github-readme-stats/pull/3312. I recently left my review with requested changes, in case if @a-s-t-e-y-a do not have enought time to do it, may be you can finish this pull request in co-authored mode. Let's wait for @a-s-t-e-y-a's response. Also feel free to choose another issue that you are interested to work on and contact me about it.
@qwerty541 can i make the required changes now
@airwakz another user already implemented this feature in https://github.com/anuraghazra/github-readme-stats/pull/3312 but some changes are still required.
@airwakz I'm okay if you finish this pull request in co-authored mode, but i do not see an easy way to do it because you don't have write access to @a-s-t-e-y-a's branch.
@qwerty541 I have a way but it is quite complex I will make changes in my report as per pull req and than I will finish the review asked by uh
@qwerty541 I have a way but it is quite complex I will make changes in my report as per pull req and than I will finish the review asked by uh
@airwakz I think that the best way will be the following:
- You should add @a-s-t-e-y-a's fork as remote repository
git remote add a-s-t-e-y-a [email protected]:a-s-t-e-y-a/github-readme-stats.git - Fetch it
git fetch a-s-t-e-y-a - Create a new local branch based on the one from which https://github.com/anuraghazra/github-readme-stats/pull/3312 was created.
- Make changes and push new branch into your own fork.
- Create a pull request in @a-s-t-e-y-a's fork on the correct branch.
- I hope i will be able to approve and merge it, or if not we should wait until @a-s-t-e-y-a will do this.
@rickstaa Have you already experienced when users worked on issue together? Do you have a better solution?
@airwakz If you didn't configured own SSH key for GitHub you can try use HTTPS instead: git remote add https://github.com/a-s-t-e-y-a/github-readme-stats.git
@qwerty541 i have used git clone and imported into my local machine can uh tell me the steps to commit here
@qwerty541 actually i encountered another issue right now again so i have cloned it now i have to make a branch in a github so that it doesnt affect my alerady done pr
@qwerty541 I have a way but it is quite complex I will make changes in my report as per pull req and than I will finish the review asked by uh
@airwakz I think that the best way will be the following:
- You should add @a-s-t-e-y-a's fork as remote repository
git remote add a-s-t-e-y-a [email protected]:a-s-t-e-y-a/github-readme-stats.git- Fetch it
git fetch a-s-t-e-y-a- Create a new local branch based on the one from which feature(top langs card): add ability to change progress bar background color in normal layout (resolves #3307) #3312 was created.
- Make changes and push new branch into your own fork.
- Create a pull request in @a-s-t-e-y-a's fork on the correct branch.
- I hope i will be able to approve and merge it, or if not we should wait until @a-s-t-e-y-a will do this.
This is what I would do in your case as well. This way you can open a new pull request in which the commits by @a-s-t-e-y-a are included. As a collaborator (i.e. maintainer), I or @qwerty541 can even rebase your changes on #3312 if we want 👍🏻.
@qwerty541 actually i encountered another issue right now again so i have cloned it now i have to make a branch in a github so that it doesnt affect my alerady done pr
It would be best if you always worked from a feature branch. For more tips on how to contribute to OS projects, please see https://opensource.guide/.
so this work onky for maintainer
No, since GRS is public @a-s-t-e-y-a's fork also is public, you should be able to add the fork as a remote and fetch all references. When people select this option, the only thing available for maintainers is pushing to people's forks directly. People can enable or disable this on their pull request.
I performed some tests and the following works when not being a maintainer:
-
git clone [email protected]:airwakz/github-readme-stats.git -
git remote add asteya [email protected]:a-s-t-e-y-a/github-readme-stats.git -
git fetch asteya -
git checkout asteya/master- This will give you aYou are in 'detached HEAD' statewarning. -
git switch -c progress_background- To fix this, you must create a new branch.
After these steps, you will have a progress_background branch with all the changes of @a-s-t-e-y-a included and you can work from there.
A guide on how this works can be found here. The difference is that you and @a-s-t-e-y-a work from the master branch instead of a feature branch. As a result, an extra step is required since your master conflicts with their master 😅. Because of this, I always advice people to use a feature branch.
@qwerty541 can uh assign me this i will make a pr soon today with the changes as uh requested
@qwerty541 can uh assign me this i will make a pr soon today with the changes as uh requested
@airwakz I left my review, check it out https://github.com/anuraghazra/github-readme-stats/pull/3388#pullrequestreview-1685645350