github-readme-stats
github-readme-stats copied to clipboard
anuraghazra
add border for "graphs"
Is your feature request related to a problem? Please describe.
Some Languages colors blend into the background of my "top languages" card
Describe the solution you'd like
I would like to have a white or some other color border around stuff like the top languages bar, to increase its visibility and looks.
Describe alternatives you've considered
No response
Additional context
No response
Hi can you assign this issue to me? I would like to work on this.
Yea of course! Thanks for considering contributing to our project 🎉. I'm looking forward to your pull request.
@aialok & @Pratik1603, this issue was assigned to @ShambhavII-Singh, but I have not yet received a PR. It looks like @vinfinity7 is also working on this issue.
@aialok @Pratik1603 I think one of you can work on this issue if still want. Since we didn't received a pull request from @ShambhavII-Singh and pull request submitted by @vinfinity7 is incorrect. Please read my review https://github.com/anuraghazra/github-readme-stats/pull/3282#pullrequestreview-1641076786 under declined pull request before you start the work.
I will be working on this issue. will report you soon and make a pull request.
I will be working on this issue. will report you soon and make a pull request.
@aialok Thanks for considering contributing to our project. I have assigned you to this issue. I'm looking forward to your pull request.
@qwerty541 I am trying to run the server on localhost but it redirect me to the main URL. I have tried to fix the problem but I am not able to see the changes. Can you tell me how to setup localhost ? I tried setting it up from contributing[dot].md but it did'nt seems like working.
@qwerty541 I am trying to run the server on localhost but it redirect me to the main URL. I have tried to fix the problem but I am not able to see the changes. Can you tell me how to setup localhost ? I tried setting it up from contributing[dot].md but it did'nt seems like working.
I think it redirects you to the main page, if you dont provide any params...
Hey @qwerty541 ! I have made some progress in the particular issue but I have a doubt. What type of feauture I have to implement like I have to hardcode the border color or I have to make an api params for border color. As I new to open source I dont have that much knowledge. If you explain me completely what I have to do. It would be really great things. Thank you ! Happy Coding !!
Hey @qwerty541 ! I have made some progress in the particular issue but I have a doubt. What type of feauture I have to implement like I have to hardcode the border color or I have to make an api params for border color. As I new to open source I dont have that much knowledge. If you explain me completely what I have to do. It would be really great things. Thank you ! Happy Coding !!
Hey, @aialok! The default behavior of the card should be kept as is. This is required since our users do not expect that card in their profile will be suddenly changed. So by default the card should miss progress bar border. You should add new optional query string parameter for stats card endpoint, for example it can be progress_bar_border_color. Progress bar border should appear only if this new parameter specified with valid hex color
Also don't forget to update API documentation
And it would be awesome if you can cover this changes with tests or at least provide link on test vercel deployment.
An example on provided screenshot looks good to me, let's also wait for @Arbee4ever's input since he wants this feature.
@qwerty541 I am trying to run the server on localhost but it redirect me to the main URL. I have tried to fix the problem but I am not able to see the changes. Can you tell me how to setup localhost ? I tried setting it up from contributing[dot].md but it did'nt seems like working.
Redirecting on the repository page when calling https://localgost:3000/ is expected behavior because of these strings:
https://github.com/anuraghazra/github-readme-stats/blob/master/vercel.json#L8-L13
Cards will be available when directly calling correct endpoints i.e. https://localhost:3000/api/?username=anuraghazra
Hey @qwerty541 ! I have made some progress in the particular issue but I have a doubt. What type of feauture I have to implement like I have to hardcode the border color or I have to make an api params for border color. As I new to open source I dont have that much knowledge. If you explain me completely what I have to do. It would be really great things. Thank you ! Happy Coding !!
Hey, @aialok! The default behavior of the card should be kept as is. This is required since our users do not expect that card in their profile will be suddenly changed. So by default the card should miss progress bar border. You should add new optional query string parameter for stats card endpoint, for example it can be
progress_bar_border_color. Progress bar border should appear only if this new parameter specified with valid hex colorAlso don't forget to update API documentation
And it would be awesome if you can cover this changes with tests or at least provide link on test vercel deployment.
An example on provided screenshot looks good to me, let's also wait for @Arbee4ever's input since he wants this feature.
Maybe also a progress_bar_border_thickness to set the thickness of the border?
Hey @qwerty541 ! I have made some progress in the particular issue but I have a doubt. What type of feauture I have to implement like I have to hardcode the border color or I have to make an api params for border color. As I new to open source I dont have that much knowledge. If you explain me completely what I have to do. It would be really great things. Thank you ! Happy Coding !!
Hey, @aialok! The default behavior of the card should be kept as is. This is required since our users do not expect that card in their profile will be suddenly changed. So by default the card should miss progress bar border. You should add new optional query string parameter for stats card endpoint, for example it can be
progress_bar_border_color. Progress bar border should appear only if this new parameter specified with valid hex color Also don't forget to update API documentation And it would be awesome if you can cover this changes with tests or at least provide link on test vercel deployment. An example on provided screenshot looks good to me, let's also wait for @Arbee4ever's input since he wants this feature.Maybe also a
progress_bar_border_thicknessto set the thickness of the border?
I'm okay with adding query string number parameter to set thickness of the border. It should not affect on anything if progress_bar_border_color was not specified.
okie okie !!! I have started working on this issue as my semester exam is going on It will take lil more time to complete it. I will update you with my progress and if I face any issue will ping you guys. Happy coding !
I have some doubt regarding API...I have implemented the feature for both border thickness and border color and its working fine but the problem is I am not able to get how is the API working. I tried going through codebase and I am not able to get how is the API working after it is taking req.query.
I have some doubt regarding API...I have implemented the feature for both border thickness and border color and its working fine but the problem is I am not able to get how is the API working. I tried going through codebase and I am not able to get how is the API working after it is taking req.query.
I hope that this article can help you https://codecrumbs.io/library/github-readme-stats
Hi, may I know if this issue is still active? I'm thinking of giving it a try, but not sure if @aialok is still working on it or have already done it.
Hi, may I know if this issue is still active? I'm thinking of giving it a try, but not sure if @aialok is still working on it or have already done it.
Go ahead. @nikelasi
Hey @qwerty541, not sure if I have to mention you here, but I have created a PR ready for your review.