github-readme-stats icon indicating copy to clipboard operation
github-readme-stats copied to clipboard

Add one_dark_pro

Open b3dyk opened this issue 3 years ago • 3 comments

This colors were taken from One Dark Pro theme in VSCode extention. Please add it and I will use it in my profile

b3dyk avatar Feb 08 '23 19:02 b3dyk

@b3dyk is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 08 '23 19:02 vercel[bot]

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

:heavy_check_mark: Theme PR does adhere to our guidelines.

Test results

  • :heavy_check_mark: one_dark_pro

Result: :heavy_check_mark: All themes are valid.

Details

One_dark_pro theme preview

title_color: #61AFEF | icon_color: #C678DD | text_color: #E5C06E | bg_color: #23272E | border_color: #3B4048

Preview Link

github-actions[bot] avatar Feb 08 '23 19:02 github-actions[bot]

@Zo-Bro-23 I'm okay with also including One Dark Pro since it is one of the most popular Vscode Themes (see https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme). @anuraghazra However made a comment about not bloating the themes library, so I will leave the decision to him. 😅

rickstaa avatar Feb 09 '23 14:02 rickstaa

@rickstaa this looks good to me, and it's from a VSCode extension. Merge?

Zo-Bro-23 avatar Feb 14 '23 01:02 Zo-Bro-23

@Zo-Bro-23 since this is one of the most popular vs code themes, I agree it can be merged when conflicts are solved. Please merge https://github.com/anuraghazra/github-readme-stats/pull/2518 before this one so that the docs README is updated. 👍🏻

rickstaa avatar Feb 14 '23 11:02 rickstaa

@b3dyk will merge after we resolve the issue in #2518!

Zo-Bro-23 avatar Feb 15 '23 01:02 Zo-Bro-23