anuraghazra
Github Stats card: Private commits count actually counts private contributions
Discussed in https://github.com/anuraghazra/github-readme-stats/discussions/2498.
Overview
On the Github stats card, when using the option count_private, it is supposed to include private commits in the total commits count. However, it actually includes private contributions in the total commits count, which is not the same thing, as explained here.
Details
The option on the stats card:
The code used to generate the total commit number actually uses a private contributions value from the Github API:
The property in the Github GraphQL API schema file, along with the comment of what it represents:
@harry-graham Thanks for bringing the distinction to our attention! The documentation could indeed be updated. Please feel free to create a PR, and I will review it. The best way to get correct commits is to remove the count_private property and deploy your Vercel instance (see https://github.com/anuraghazra/github-readme-stats#deploy-on-your-own-vercel-instance). GRS will then have access to your private commits.
I think we should remove the count_private option altogether, unless we plan to add a totalContributions field in the future.
See #2504 (comment).
