anuraghazra
added merge others langs option
An option for the Language Card that specifically allows showing an "Other" percentage when limiting the amount of languages shown via langs_count.
Fixes #1548
Old PR #2119
@RedHeadphone is attempting to deploy a commit to the github readme stats Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Base: 97.25% // Head: 97.26% // Increases project coverage by +0.01% :tada:
Coverage data is based on head (
8f64fab) compared to base (1120006). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #2491 +/- ##
==========================================
+ Coverage 97.25% 97.26% +0.01%
==========================================
Files 24 24
Lines 4152 4172 +20
Branches 380 383 +3
==========================================
+ Hits 4038 4058 +20
Misses 112 112
Partials 2 2
| Impacted Files | Coverage Ξ | |
|---|---|---|
| api/top-langs.js | 95.45% <100.00%> (+0.10%) |
:arrow_up: |
| src/cards/top-languages-card.js | 100.00% <100.00%> (ΓΈ) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@RedHeadphone Thanks again for your PR. I again gave it an approval review. I, however, would like to have another approval from any of the other collaborators before merging into the main branch (i.e. @anuraghazra, @Zo-Bro-23).
Also, when this is merged, feel free to create a feature request about allowing users to show hidden languages in the other array (see https://github.com/anuraghazra/github-readme-stats/pull/2119#issuecomment-1272550695). I am afraid this requires a breaking change, but we can discuss it there.
I don't quite get the need for this feature π€
If someone is deliberately saying that they want to only show 10 langs at max via langs_count why do they need to again show a vague "Others" as language?
@anuraghazra This feature can be for those who want to show that they are not limited to the languages displayed in the stats card. So showing 'Others' language in the stats card can convey that.
cc: @rickstaa @Zo-Bro-23
@RedHeadphone I'm still okay with merging this feature if @anuraghazra approves ππ».