anuraghazra
dark_knight theme
@harry-io is attempting to deploy a commit to the github readme stats Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Automated Theme Preview
Hi, thanks for the theme contribution. Please read our theme contribution guidelines.
We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.
Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.
:heavy_check_mark: Theme PR does adhere to our guidelines.
Test results
- :heavy_check_mark: dark_knight
Result: :heavy_check_mark: All themes are valid.
Details
Dark_knight theme preview
title_color: #9fef00 | icon_color: #9fef00 | text_color: #9fef00 | bg_color: #141d2b | border_color: #9fef00
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Zo-Bro-23, thanks for reviewing this theme. I approved the PR but would like you to know which Vscode theme this was based on to keep the naming consistent. @harry-io, can you please tell us which piece you based this card theme on?
Looks like it isn't based on a theme. It looks good though; shall I merge?
@Zo-Bro-23, before merging this PR, I still would like an answer from @harry-io about the Vscode theme he based this theme on. This way, we ensure we don't need to change the name later, which results in breaking changes. I think it was based on https://github.com/UstymUkhman/matrix-theme, but the green colour needs to be changed a bit (see https://github.com/UstymUkhman/matrix-theme/blob/master/themes/Matrix-color-theme.json). Instead, I would merge a Vscode theme close to a fully custom piece. Another option would be to create the accompanying Vscode theme (see https://medium.com/wearelaika/vscode-create-your-own-custom-theme-extension-96c67bd753f6).
Sorry for the late reply, I wanted this to be on the "hackthebox" VS Code theme (https://github.com/silofy/hackthebox).
Another option would be to create the accompanying Vscode theme (see https://medium.com/wearelaika/vscode-create-your-own-custom-theme-extension-96c67bd753f6).
@rickstaa the whole point of merging VSCode only themes is to ensure that only popular themes get merged. I don't think we should go as far as to create our own VSCode theme, since it beats the purpose of the VSCode rule in the first place! We can merge an unpopular theme if it looks good; that's up to us. No point spending extra time making a VSCode theme since we only want to use this theme for GRS. @harry-io has replied anyways, so we can merge this :+1:
hackthebox
It doesn't have the same colours as hacker box though 🤔. I would slightly change the green colour and merge it as matrix (see https://github.com/UstymUkhman/matrix-theme).
hackthebox
It doesn't have the same colours as hacker box though 🤔. I would slightly change the green colour and merge it as
matrix(see https://github.com/UstymUkhman/matrix-theme).
It's this theme @harry-io meant.
hackthebox
It doesn't have the same colours as hacker box though thinking. I would slightly change the green colour and merge it as
matrix(see https://github.com/UstymUkhman/matrix-theme).It's this theme @harry-io meant.
No, this is the theme that closely resembles the colours he used (see https://github.com/UstymUkhman/matrix-theme/blob/master/themes/Matrix-color-theme.json#L320). I think the colours should be changed slightly, and these PRs can be merged as matrix.
hackthebox
It doesn't have the same colours as hacker box though thinking. I would slightly change the green colour and merge it as
matrix(see https://github.com/UstymUkhman/matrix-theme).It's this theme @harry-io meant.
No, this is the theme that closely resembles the colours he used (see https://github.com/UstymUkhman/matrix-theme/blob/master/themes/Matrix-color-theme.json#L320). I think the colours should be changed slightly, and these PRs can be merged as
matrix.
dde638b updated the colors. Are you sure it still resembles the matrix theme more than the hackthebox one? (I'm colorblind, so I'm just going by the hex codes here; these are the hex codes for the GRS theme)
hackthebox
It doesn't have the same colours as hacker box though thinking. I would slightly change the green colour and merge it as
matrix(see https://github.com/UstymUkhman/matrix-theme).It's this theme @harry-io meant.
No, this is the theme that closely resembles the colours he used (see https://github.com/UstymUkhman/matrix-theme/blob/master/themes/Matrix-color-theme.json#L320). I think the colours should be changed slightly, and these PRs can be merged as
matrix.dde638b updated the colors. Are you sure it still resembles the matrix theme more than the hackthebox one? (I'm colorblind, so I'm just going by the hex codes here; these are the hex codes for the GRS theme)
No problem. The hackthebox theme has a lot more colours, while the matrix theme only is green.
hackthebox
It doesn't have the same colours as hacker box though thinking. I would slightly change the green colour and merge it as
matrix(see https://github.com/UstymUkhman/matrix-theme).It's this theme @harry-io meant.
No, this is the theme that closely resembles the colours he used (see https://github.com/UstymUkhman/matrix-theme/blob/master/themes/Matrix-color-theme.json#L320). I think the colours should be changed slightly, and these PRs can be merged as
matrix.dde638b updated the colors. Are you sure it still resembles the matrix theme more than the hackthebox one? (I'm colorblind, so I'm just going by the hex codes here; these are the hex codes for the GRS theme)
No problem. The hackthebox theme has a lot more colours, while the matrix theme only is green.
Got you! Hackthebox has a 100 stars and matrix 6 though, so they might not be very popular themes anyways.