github-readme-stats icon indicating copy to clipboard operation
github-readme-stats copied to clipboard

fix: Fetch all repos for top languages

Open MatteoPierro opened this issue 3 years ago β€’ 7 comments

This fixed https://github.com/anuraghazra/github-readme-stats/issues/1177

MatteoPierro avatar Oct 04 '22 11:10 MatteoPierro

@MatteoPierro is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 04 '22 11:10 vercel[bot]

Codecov Report

Base: 97.32% // Head: 97.33% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (a4b2347) compared to base (af97e57). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head a4b2347 differs from pull request most recent head 3741157. Consider uploading reports for the commit 3741157 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2111   +/-   ##
=======================================
  Coverage   97.32%   97.33%           
=======================================
  Files          22       22           
  Lines        3592     3603   +11     
  Branches      322      322           
=======================================
+ Hits         3496     3507   +11     
  Misses         95       95           
  Partials        1        1           
Impacted Files Coverage Ξ”
src/fetchers/top-languages-fetcher.js 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 04 '22 12:10 codecov[bot]

Could you review it? @rickstaa πŸ™

MatteoPierro avatar Oct 07 '22 13:10 MatteoPierro

LGTM

tc-imba avatar Oct 09 '22 07:10 tc-imba

@MatteoPierro Thanks for your pull request! I accepted your PR and added the hacktoberfest-accepted label. The contribution should appear in your Hacktoberfest dashboard and be accepted in 7 days. πŸŽ‰ I will, however, not merge it now due to the PATs rate limit problems we are experiencing (see https://github.com/anuraghazra/github-readme-stats/issues/1471#issuecomment-1271551425). Including multiple pages would deplete the PATs even faster. We might merge it later by adding an environment variable that can be used to disable this feature on the public instance (see https://github.com/anuraghazra/github-readme-stats/pull/2159). For this, we, however, have to run several tests to ensure that the maxDuration limit of Vercel is not being hit (see https://vercel.com/blog/customizing-serverless-functions).

rickstaa avatar Oct 09 '22 08:10 rickstaa

adding an environment variable that can be used to disable this feature

hello ! imo this is the best solution, or an opt-in approach where it's 100 by default, and we can increment the count on our self-hosted instances. For some cases, this is the only use case for self-hosting it, and would be useful.

thanks !

mirsella avatar Mar 05 '24 21:03 mirsella

@rickstaa

I noticed that #2159 is merged with the new env var FETCH_MULTI_PAGE_STARS. This pull request only adds multi-page query of the stats card, but similar changes to the lang card are still not applied now.

I'm not sure whether you have tested the maxDuration limitation of personal deployed vercel, but considering the PR is merged I think it's ok. Is it possible to port FETCH_MULTI_PAGE_STARS to the lang card as well? Or we can use a more generalized env such as FETCH_MULTI_PAGE instead. I can write a new PR for this later.

tc-imba avatar May 15 '24 06:05 tc-imba