fix: improve boolean parse behaviour
This commit ensures that incorrectly typed properties like hide_border=trsdfaf use their default values.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| github-readme-stats | ✅ Ready (Inspect) | Visit Preview | Nov 21, 2022 at 9:09AM (UTC) |
Codecov Report
Base: 96.73% // Head: 96.55% // Decreases project coverage by -0.17% :warning:
Coverage data is based on head (
3bd753d) compared to base (4b656eb). Patch coverage: 54.54% of modified lines in pull request are covered.
:exclamation: Current head 3bd753d differs from pull request most recent head 6d3a473. Consider uploading reports for the commit 6d3a473 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #2029 +/- ##
==========================================
- Coverage 96.73% 96.55% -0.18%
==========================================
Files 22 22
Lines 3824 3799 -25
Branches 322 325 +3
==========================================
- Hits 3699 3668 -31
- Misses 123 129 +6
Partials 2 2
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/common/utils.js | 98.64% <54.54%> (-0.92%) |
:arrow_down: |
| src/translations.js | 99.21% <0.00%> (-0.53%) |
:arrow_down: |
| src/getStyles.js | 71.87% <0.00%> (-0.22%) |
:arrow_down: |
| api/index.js | 95.78% <0.00%> (-0.09%) |
:arrow_down: |
| src/calculateRank.js | 99.00% <0.00%> (-0.04%) |
:arrow_down: |
| themes/index.js | 100.00% <0.00%> (ø) |
|
| src/cards/stats-card.js | 100.00% <0.00%> (ø) |
|
| src/cards/wakatime-card.js | 100.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@anuraghazra, I made a very small change to the parseBoolean function to prevent confusion.
@anuraghazra I improved the syntax a bit, so the function behaviour is more clear. I think we are now good to merge.
@anuraghazra, I think this PR is good to go.