github-readme-stats icon indicating copy to clipboard operation
github-readme-stats copied to clipboard

Add light and dark Catppuccin themes, #1977

Open cosmojg opened this issue 3 years ago • 3 comments

"Catppuccin Latte" and "Catppuccin Mocha" come from the official Catppuccin theme, available here: https://github.com/catppuccin/github-readme-stats

cosmojg avatar Sep 08 '22 07:09 cosmojg

@cosmojg is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 08 '22 07:09 vercel[bot]

Automated Theme Preview

title_color: #179299 | icon_color: #8839ef | text_color: #4c4f69 | bg_color: #eff1f5

Preview Link

Hi, thanks for the theme contribution, please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes which have good color combination to minimize bloating the themes collection.

Also note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection you can use card customization options

anuraghazra avatar Sep 08 '22 07:09 anuraghazra

@cosmojg Thanks for implementing this theme. Sadly the current colours used by the theme are incompatible with the AA contrast ratio. The title colour has to be changed before we can merge this PR. The question, however, is if we want to do it here or if we want to raise an issue on https://github.com/catppuccin/github-readme-stats.

Since this is an often requested theme, I assigned myself to this issue, so I don't forget. I can, however, not give an ETA since I'm currently very busy with my graduation, and I first want to implement https://github.com/anuraghazra/github-readme-stats/issues/1659 before I merge any new themes.

rickstaa avatar Sep 15 '22 11:09 rickstaa

This PR has been automatically closed due to inactivity. Please feel free to reopen it if you need to continue working on it. Thank you for your contributions.

rickstaa avatar Oct 18 '22 14:10 rickstaa

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

:x: Theme PR does not adhere to our guidelines.

Test results

  • :x: catppuccin_latte
  • :heavy_check_mark: catppuccin_mocha

Result: :x: Some themes are invalid.

Unfortunately, your theme PR contains an error or does not adhere to our theme guidelines. Please fix the issues below, and we will review your
PR again. This pull request will automatically close in 15 days if no changes are made. After this time, you must re-open the PR for it to be reviewed.

Details

Catppuccin_latte theme preview

title_color: #179299 | icon_color: #8839ef | text_color: #4c4f69 | bg_color: #eff1f5

Preview Link

Catppuccin_mocha theme preview

title_color: #94e2d5 | icon_color: #cba6f7 | text_color: #cdd6f4 | bg_color: #1e1e2e

Preview Link

github-actions[bot] avatar Oct 18 '22 14:10 github-actions[bot]

Codecov Report

Base: 95.07% // Head: 96.66% // Increases project coverage by +1.59% :tada:

Coverage data is based on head (17096fc) compared to base (192170c). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2009      +/-   ##
==========================================
+ Coverage   95.07%   96.66%   +1.59%     
==========================================
  Files          22       22              
  Lines         771     3809    +3038     
  Branches      208      323     +115     
==========================================
+ Hits          733     3682    +2949     
- Misses         33      125      +92     
+ Partials        5        2       -3     
Impacted Files Coverage Δ
themes/index.js 100.00% <100.00%> (ø)
src/fetchers/top-languages-fetcher.js 87.32% <0.00%> (-12.68%) :arrow_down:
src/fetchers/stats-fetcher.js 91.10% <0.00%> (-0.21%) :arrow_down:
src/common/icons.js 100.00% <0.00%> (ø)
src/cards/repo-card.js 100.00% <0.00%> (ø)
src/cards/stats-card.js 100.00% <0.00%> (ø)
src/common/blacklist.js 100.00% <0.00%> (ø)
src/cards/top-languages-card.js 100.00% <0.00%> (ø)
src/common/createProgressNode.js 100.00% <0.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 18 '22 14:10 codecov[bot]

@cosmojg Please fix the warnings above for your theme to get merged. I will increase the stale theme time to 30 days, by the way. Fifteen days is a bit aggressive. 😅

rickstaa avatar Oct 18 '22 14:10 rickstaa

This PR has been automatically closed due to inactivity. Please feel free to reopen it if you need to continue working on it. Thank you for your contributions.

github-actions[bot] avatar Nov 08 '22 00:11 github-actions[bot]