github-readme-stats icon indicating copy to clipboard operation
github-readme-stats copied to clipboard

feat(stats): add 'not_bold' option to stats card

Open rickstaa opened this issue 4 years ago • 5 comments

Implements #1426. @anuraghazra I'm not sure if we want to implement this feature in the main branch but I wanted to give people a pull request they can use might they want this feature.

rickstaa avatar Nov 22 '21 16:11 rickstaa

@rickstaa is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 22 '21 16:11 vercel[bot]

Text_bold=undefined

undefined

text_bold=false

not bold

text_bold=true

not bold

rickstaa avatar Nov 22 '21 18:11 rickstaa

In the current form, the title is kept bold. We can however also change that behaviour. @anubhav217 did not provide a detailed explanation in #1426.

rickstaa avatar Nov 22 '21 18:11 rickstaa

Given that the header is implemented here:

https://github.com/anuraghazra/github-readme-stats/blob/ecd7d98a3c5ab9f50706458065a314b2c4f7f98e/src/common/Card.js#L153

I think it is not worth it since it will complicate the codebase.

rickstaa avatar Nov 22 '21 18:11 rickstaa

@anuraghazra I think this can be safely merged.

rickstaa avatar Feb 20 '22 16:02 rickstaa

Codecov Report

Base: 95.18% // Head: 95.20% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (8315028) compared to base (eacc3cd). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1468      +/-   ##
==========================================
+ Coverage   95.18%   95.20%   +0.01%     
==========================================
  Files          22       22              
  Lines         789      792       +3     
  Branches      216      219       +3     
==========================================
+ Hits          751      754       +3     
  Misses         33       33              
  Partials        5        5              
Impacted Files Coverage Δ
api/index.js 90.47% <ø> (ø)
src/getStyles.js 56.25% <ø> (ø)
src/cards/stats-card.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 17 '22 11:09 codecov[bot]