anuraghazra
Added pr reviews to stats
Fixes: #1394
Added code reviews to stats card:
What do you think about this feature? They do not affect the rank at the moment, that's something that should be maybe added later. Also translations just default to english.
Someone is attempting to deploy a commit to the github readme stats Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Patch coverage: 100.00% and project coverage change: +0.02 :tada:
Comparison is base (
66e5492) 97.59% compared to head (14eb504) 97.61%.
Additional details and impacted files
@@ Coverage Diff @@
## master #1404 +/- ##
==========================================
+ Coverage 97.59% 97.61% +0.02%
==========================================
Files 24 24
Lines 4824 4869 +45
Branches 448 449 +1
==========================================
+ Hits 4708 4753 +45
Misses 115 115
Partials 1 1
| Impacted Files | Coverage Δ | |
|---|---|---|
| api/index.js | 96.22% <100.00%> (+0.07%) |
:arrow_up: |
| src/cards/stats-card.js | 100.00% <100.00%> (ø) |
|
| src/common/icons.js | 100.00% <100.00%> (ø) |
|
| src/fetchers/stats-fetcher.js | 92.74% <100.00%> (+0.11%) |
:arrow_up: |
| src/translations.js | 99.77% <100.00%> (+0.01%) |
:arrow_up: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Okay maybe we can add this PR review stat.
But we need to do it in a way which is non-breaking... TBH from initially my API decision wasn't that great (well i made this project in 15min so what can you expect)
By non-breaking, i mean that the review stat should not suddenly pop up on everyone's cards otherwise the card height will increase and will break the layout for many people on the readmes.
Maybe we can do a opt-in solution like a param show=pr_reviews
Yeah I agree. Changed the PR so that "reviews" are hidden by default and visible only when a separate "show" parameter is passed in. Also updated readme about the new feature.
Hey @FayasNoushad , I saw this pr is approved already, what should we do to push this forward then, I'm eager for this feature.
@kerthcet I fully understand that this is a feature you want. Pinging the repository author, however, does not speed up the PR review process. We already got an alert when you posted https://github.com/anuraghazra/github-readme-stats/pull/1404#issuecomment-1045631301. It only puts more stress on the repository collaborators who maintain this project in their free time.
There are currently several other PRs open which have a higher priority (e.g. https://github.com/anuraghazra/github-readme-stats/issues/1 and https://github.com/anuraghazra/github-readme-stats/pull/1186). We, therefore, can not give you an ETA for this feature.
I would therefore advise you to fork this project, for now, merge #1404 and create your own vercel instance (see https://github.com/anuraghazra/github-readme-stats#deploy-on-your-own-vercel-instance).
Hope that helps. Let me know if you have any questions
Sorry guys, my intension here was to check whether this pr is forgotten for approved since last year. Thanks for syncing the information. Apologize again.
@kerthcet No problem I understand. Feel free to let me know if you run into problems merging this PR on your own fork and deploying it on your own vercel instance.
This looks good, will give final review soon.
GOSH I still regret the decision to add the hide param. Should've been better to put show param as default.
@Marcholio @rickstaa
I have merged master branch and refactored the code a little. Please check it and write about your thoughts. If you didn't liked the changed feel free to force push them back.
TODO:
- [ ] translations #2825
- [x] docs
