github-readme-stats
github-readme-stats copied to clipboard
Cleanup Tests and Warnings in them
Description
I've cleanuped the tests a bit and fixed some warnings. Jest only spitted out the warning that toBeEmpty()
is deprecated and toBeDOMElement()
should be used instead, but i also refactored other tests in this PR. Mainly renderStatsCard.test.js
, because it had multiple duplicate code-fragments that should be refactored for faster readability.
Code
- Exchanged deprecated method
- Added
expectColors()
to avoid duplicate code fragments - Removed unused imports
- Removed unused variables
Types of changes
- Enhancement
- Refactor
Reference
- toBeDOMElement
- #705 (only minor improvements)
@distrustME is attempting to deploy a commit to the github readme stats Team on Vercel.
A member of the Team first needs to authorize it.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
7d4c49b
) 98.02% compared to head (80c7163
) 98.02%.
Additional details and impacted files
@@ Coverage Diff @@
## master #1205 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 27 27
Lines 6275 6275
Branches 549 549
=======================================
Hits 6151 6151
Misses 121 121
Partials 3 3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.