Anurag Rajawat

Hi! @DevPJ9 Thanks a lot for contributing to Eclipse JKube 👍 In order to contribute to Eclipse, you would need to create an [Eclipse Account](https://accounts.eclipse.org/) and Sign [Eclipse Contributor Agreement](https://accounts.eclipse.org/user/login?destination=user/eca)....

@baruKreddy please recheck AC before making your PR ready for review, especially regarding JUnit4 assertions.

> @anurag-rajawat Here do you think I made any mistake on assertions for Junit4 changes? No, but you forgot to replace JUnit's assertions with AssertJ

> Please point me out https://github.com/eclipse/jkube/blob/8271c241d073fb95c5557e603dd83ce0d984024e/jkube-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/TriggersAnnotationEnricherTest.java#L80-L88 https://github.com/eclipse/jkube/blob/8271c241d073fb95c5557e603dd83ce0d984024e/jkube-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/TriggersAnnotationEnricherTest.java#L115-L123 https://github.com/eclipse/jkube/blob/8271c241d073fb95c5557e603dd83ce0d984024e/jkube-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/TriggersAnnotationEnricherTest.java#L153-L163 https://github.com/eclipse/jkube/blob/8271c241d073fb95c5557e603dd83ce0d984024e/jkube-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/TriggersAnnotationEnricherTest.java#L194-L207 https://github.com/eclipse/jkube/blob/8271c241d073fb95c5557e603dd83ce0d984024e/jkube-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/TriggersAnnotationEnricherTest.java#L236 https://github.com/eclipse/jkube/blob/8271c241d073fb95c5557e603dd83ce0d984024e/jkube-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/RevisionHistoryEnricherTest.java#L85 https://github.com/eclipse/jkube/blob/8271c241d073fb95c5557e603dd83ce0d984024e/jkube-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/MavenIssueManagementEnricherTest.java#L58 https://github.com/eclipse/jkube/blob/8271c241d073fb95c5557e603dd83ce0d984024e/jkube-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/openshift/RouteEnricherTest.java#L292 https://github.com/eclipse/jkube/blob/8271c241d073fb95c5557e603dd83ce0d984024e/jkube-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/openshift/RouteEnricherTest.java#L221 https://github.com/eclipse/jkube/blob/8271c241d073fb95c5557e603dd83ce0d984024e/jkube-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/openshift/RouteEnricherTest.java#L200 https://github.com/eclipse/jkube/blob/8271c241d073fb95c5557e603dd83ce0d984024e/jkube-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/openshift/RouteEnricherTest.java#L187 https://github.com/eclipse/jkube/blob/8271c241d073fb95c5557e603dd83ce0d984024e/jkube-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/openshift/RouteEnricherTest.java#L172 https://github.com/eclipse/jkube/blob/8271c241d073fb95c5557e603dd83ce0d984024e/jkube-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/openshift/AutoTLSEnricherTest.java#L120-L149 I'll take care of these but please remember for the next time.

@Sayan2908 why did you open a new PR for the same issue?

Hi! @Kumar-Rishav-py Thanks a lot for contributing to Eclipse JKube 👍 In order to contribute to Eclipse, you would need to create an [Eclipse Account](https://accounts.eclipse.org/) and Sign [Eclipse Contributor Agreement](https://accounts.eclipse.org/user/login?destination=user/eca)....

@shawkins I would love to work on this, assign this to me. Thanks!

@manusa this epic is completed, we can close this 🚀

I am very grateful to have mentors like both of you and this was not possible without your support and regular feedback. Thanks a lot 🙏

Hi @drorIvry! Can you tell me where are the tests and how are you verifying your changes? So without tests how can we add CI/CD?