Anurag Rajawat

Results 49 comments of Anurag Rajawat

@shawkins Do we need to remove the `mock` line from the `pom.xml` files present in extensions sub-modules or completely remove the mock modules present in the extensions sub-modules?

@rohanKanojia please assign this to me

@manusa I rewrite these assertions https://github.com/eclipse/jkube/blob/cccc2864555f9e0959020d4c4fe4e817d587f865/jkube-kit/generator/webapp/src/test/java/org/eclipse/jkube/generator/webapp/handler/JettyAppSeverHandlerTest.java#L48-L49 like ```java assertThat(Files.createDirectory(temporaryFolder.toPath().resolve("META-INF"))) .satisfies(p -> assertThat(new File(p.toFile(), "jetty-logging.properties").createNewFile()).isTrue()); assertThat(Files.createDirectory(temporaryFolder.toPath().resolve("META-INF-1337"))) .satisfies(p -> assertThat(new File(p.toFile(), "context.xml").createNewFile()).isTrue()); ``` please tell me a better way to assert these.

@rohanKanojia when I rename `WildFlyAppSeverHandlerTest` test class to `WildFlyAppServerHandlerTest`, git shows it was deleted and a new one created but works fine for `JettyAppSeverHandlerTest` and `TomcatAppSeverHandlerTest` , why? Also `git...

Now in changed files on github, it is deleted and a new one created, why?

Here https://github.com/eclipse/jkube/pull/1691/files#diff-a4a2fab70e7a3949683a25703eb908ea2213b30060d6989d2522524df66d5d46

> I created [anurag-rajawat#2](https://github.com/anurag-rajawat/jkube/pull/2) with some suggestions @manusa thank you so much!