onenote-desktop icon indicating copy to clipboard operation
onenote-desktop copied to clipboard

Please Add Dark Mode Feature.

Open Awadesh365 opened this issue 1 year ago • 4 comments

This will be very helpful, if You'll add Dark mode in this app,

Thanks.

Awadesh365 avatar Jul 22 '23 07:07 Awadesh365

Hi, this app just serves up Microsoft's OneNote website in a desktop application like container. MS has not implemented dark mode on the website, so getting dark mode in here isn't as easy as flipping a switch.

But there is a hacky way around that. I'm about to post an update today or tomorrow. I'll try it out and see how well it works.

anujdatar avatar Jul 22 '23 08:07 anujdatar

Hey @anujdatar, really cool application, thank you for building it!

I was just thinking, it could be relatively easy to implement a dark mode. You could have the web browser inside electron download or come packaged with an extension like dark reader. Its MIT license would allow you to legally use it in the project (https://github.com/darkreader/darkreader/blob/main/LICENSE). Alternatively, you could use some of the code from the dark reader to emulate similar behavior if you didn't want to side load the extension.

RheseSoemo avatar Sep 15 '23 19:09 RheseSoemo

Hi, thanks.. I'm glad you find this app useful. Adding dark mode has been on my todo list for some time now.. I did spend some time exploring the idea without trying to put OneNote in an iframe, but I was only partially successful.

I have been trying my best to avoid additional bloat, so I did not want to and another layer between electron and the OneNote webapp. Unfortunately, I have not been able to spend much time developing this app lately. I can barely, just about, update the app with new electron versions.

I will look into what you have suggested, and it looks promising. But I can't give you a concrete timeline today. I will try my best to implement this asap.

anujdatar avatar Sep 15 '23 20:09 anujdatar

I have used dark reader in the past, but I did not know it was open source.. I'll take a look at it over the weekend or something.. @RheseSoemo thanks for letting me know

anujdatar avatar Sep 15 '23 20:09 anujdatar