component icon indicating copy to clipboard operation
component copied to clipboard

Checkbox doesn't have "Check" Icon in it?

Open TheStarkster opened this issue 1 year ago • 1 comments

I was rendering checkbox component in my AntV S2 table and i see when the checkbox is checked, there's just color fill, but no icon in it, Is that normal? Or am i doing something wrong?

Screenshot 2024-08-24 at 2 11 32 PM
this.append(new Checkbox({
                style: {
                    boxX: this.meta.x + 10,
                    boxY: this.meta.y + 10,
                    checked: this.selectedRows?.includes(Number(this.meta.rowIndex)),
                    checkedX: this.meta.x + 10,
                    checkedY: this.meta.y + 10,
                },
            }))

TheStarkster avatar Aug 24 '24 08:08 TheStarkster

On further investigation it seems no property starting with prefix "checked" are working checkedX, checkedY etc. but individual boolean property checked works fine as you can also see in the screenshot in the comment before

TheStarkster avatar Aug 25 '24 15:08 TheStarkster

Usage reference from antd. What is the meaning of "no icon"?

hustcc avatar Dec 03 '24 02:12 hustcc

no icon

I meant there's no "check" within the checkbox, notice in the screenshot i've provided, it's just blue box there's suppose to be a white check

TheStarkster avatar Dec 04 '24 09:12 TheStarkster

yes, we have no check shape. Are you interested in taking on this task with a pr?

image

hustcc avatar Dec 04 '24 12:12 hustcc

@hustcc sure, in-fact I fixed it already, Giving a PR shortly have a look👇

Before after minimal skincare Instagram post

TheStarkster avatar Dec 17 '24 10:12 TheStarkster