选中大量节点时性能差

[OpportunityLiu]

Expected Behavior

多选时仅更新一次

Current Behavior

https://github.com/antvis/X6/blob/14dc9927888596a9cde26f0a94f76b0e9e642775/packages/x6/src/addon/selection/index.ts#L824

https://github.com/antvis/X6/blob/14dc9927888596a9cde26f0a94f76b0e9e642775/packages/x6/src/addon/selection/index.ts#L824

多选时更新多次

Possible Solution

Steps To Reproduce

1. 创建大量节点
2. 全选节点

Error Message & Stack Trace

<!-- Provide a log message if relevant -->

Additional Context

Your Environment

• x6: 1.26.1
• OS: [e.g. macOS Sierra 10.12.3]
• Browser: [e.g. chrome 78.0.3904.108]

[OpportunityLiu]

目前使用的 fix：

const updateContainer = Selection.prototype.updateContainer;

Selection.prototype.updateContainer = function () {
    if (this.updateContainerId) {
        cancelAnimationFrame(this.updateContainerId);
        this.updateContainerId = undefined;
    }

    this.updateContainerId = requestAnimationFrame(() => {
        this.updateContainerId = undefined;
        updateContainer.call(this);
    });
};

但是拖动的性能还是很差，用了 pointerEvents: 'none' 以后 following: false 就不起作用了

[drl990114]

I set the following settings in the graph, so that the dragging will not perform the full rendering of the component, but this seems to prevent the mouse events from being passed to the component.

If you don't need a lot of interaction between components, this may solve part of the performance problem. But this is obviously not a good solution. I also hope that someone can provide a better solution.

selecting: {
        showNodeSelectionBox: true,
        following: false
}

[OpportunityLiu]

That's also not working in current version, see #1328

[drl990114]

This seems to be a problem in the new version, there is no such bug in version 1.25.3

[NewByVector]

1. x6 优化：框选的时候只有在最后触发一次 updatContainer
2. 在 selecting 中你开启 useCellGeometry 配置，看下拖动性能是否有改善

[OpportunityLiu]

其实主要还是 x6-widget-transform 太慢了，一个cell就是10个DOM element，明明设了orth: false 都不打折的（到处都在微操 DOM，这个地方居然用 css 偷懒了）

现在我的解决方案是重写 Selection 插件添加选中前通知

import { Collection } from '@antv/x6';
import { Selection } from '@antv/x6/lib/addon/selection';

/** 自定义 selection */
export class CustomSelection extends Selection {
    /** 添加事件 */
    protected override onCollectionUpdated(args: Collection.EventArgs['updated']): void {
        const myArgs = {
            added: args.added,
            removed: args.removed,
            options: args.options,
            selected: this.cells,
        };
        void this.trigger('selection:changing', myArgs);
        void this.graph.trigger('selection:changing', myArgs);
        super.onCollectionUpdated(args);
    }
}

然后在选中过多时把 transform 直接关掉（还有 snapline）

// 优化选中性能
graph.on('selection:changing', () => {
    const l = graph.getSelectedCellCount();
    this.tooManySelection = l > 20;
    graph.container.classList.toggle('hide-selection-box-node', !this.tooManySelection);
    graph.toggleSnapline(l < 2 && !!(command.modifiers & KeyModifier.Shift));
    graph.hideSnapline();
});

resizing: {
    enabled: () => !this.tooManySelection,
}
rotating: {
    enabled: () => !this.tooManySelection,
},

然后拿 x6-widget-selection 画的框当选中框

.hide-selection-box-node .x6-widget-selection-box-node {
  display: none;
}

[OpportunityLiu]

mxGraph里这个行为是默认的

[OpportunityLiu]

另外，checkView 可以实现 viewport 外的 cell 不渲染（这也是我们从 mxGraph 切换过来的主要原因），但是对选中框啥的就没啥办法了。导致一个节点数多的图形，普通拖动浏览都十分流畅，一按 Ctrl+A 卡1分钟。

[OpportunityLiu]

而且你这个 fix 对于编程的大量选中也不生效啊，Ctrl+A 啥的照卡不误

[NewByVector]

@OpportunityLiu 老哥稳呀

[wooderpecker]

多选后拖拉卡顿，我的解决方法是监听到多选后，根据选中的graph.selection.widget.$selectionContainer[0] 生成一个同等长宽，位置的group，然后把节点加到group里面。实现拖拉不卡顿。取消选中的时候再从group中把节点抽取出来放回canvas，然后删掉group。 后续作者是否可以加个配置项，在多选的时候实现这种功能？

[x6-bot[bot]]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the AntV community! 💪💯

[kiki-oo]

多选后拖拉卡顿，我的解决方法是监听到多选后，根据选中的graph.selection.widget.$selectionContainer[0] 生成一个同等长宽，位置的group，然后把节点加到group里面。实现拖拉不卡顿。取消选中的时候再从group中把节点抽取出来放回canvas，然后删掉group。 后续作者是否可以加个配置项，在多选的时候实现这种功能？

这么处理渲染selectionView的耗时只用花费一次。但是看performance中layout调用jquery耗时还是100ms，有没有提高方法呀

[x6-bot[bot]]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the AntV community! 💪💯

[x6-bot[bot]]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the AntV community! 💪💯

[mugo1993-ss]

另外，checkView 可以实现 viewport 外的 cell 不渲染（这也是我们从 mxGraph 切换过来的主要原因），但是对选中框啥的就没啥办法了。导致一个节点数多的图形，普通拖动浏览都十分流畅，一按 Ctrl+A 卡1分钟。

请问大佬怎么实现，渲染6000个节点和6000条边，界面卡死的问题呢？

[zzjjbbaa]

另外，checkView 可以实现 viewport 外的 cell 不渲染（这也是我们从 mxGraph 切换过来的主要原因），但是对选中框啥的就没啥办法了。导致一个节点数多的图形，普通拖动浏览都十分流畅，一按 Ctrl+A 卡1分钟。

请问大佬怎么实现，渲染6000个节点和6000条边，界面卡死的问题呢？

同问，大量图元的渲染问题，持续关注

[bighhhh]

卡顿是因为开启了showNodeSelectionBox配置，然后多选时会每一个node绘制一个x6-widget-selection-box的选中框，而每次拖动都会把这个选中框移除然后重新插入。 showNodeSelectionBox设置为false时性能会提升4-5倍，但是多选不显示最外边大的选择框，这问题就很纠结

[bighhhh]

这个地方如果改成showNodeSelectionBox启用后，如果选择一个节点则渲染x6-widget-selection-box框，如果多选则只渲染最外层大框而不渲染每一个节点的选中框，则问题就解决了

[bighhhh]

目前有个解决方案，可以使400多个不卡顿https://juejin.cn/post/7278974923682644024