S2 icon indicating copy to clipboard operation
S2 copied to clipboard

[WIP] feat(interaction): 新增选中/高亮单元格 & 滚动 API

Open lijinke666 opened this issue 11 months ago • 3 comments

👀 PR includes

✨ Feature

  • [x] New feature

📝 Description

选中单元格 API 调整/完善

selectHeaderCell 变更为 changeCell, 支持所有类型单元格的选中。同时支持 选中 (selectCell)高亮 (highlightCell) 等语法糖, 现有 API 可以实现 (如: s2.interaction.changeState()), 但成本过高, 开发者需要理解部分源码逻辑, 简化从而满足外部逻辑主动触发的场景.

- s2.interaction.selectHeaderCell(selectHeaderCellInfo: SelectHeaderCellInfo)
+ s2.interaction.changeCell(options: ChangeCellOptions)

+ s2.interaction.selectCell(cell: S2CellType)
+ s2.interaction.highlightCell(cell: S2CellType)

选中

Kapture 2024-03-07 at 15 19 16

高亮

Kapture 2024-03-07 at 15 18 23

滚动 API 调整/完善

滚动 API s2.updateScrollOffset 移除,统一至 s2.interaction 命名空间下, 保持 API 一致性。同时支持 scrollToCellscrollToTop 等语法糖。

- s2.updateScrollOffset(offsetConfig: ScrollOffsetConfig)
+ s2.interaction.scrollTo(offsetConfig: ScrollOffsetConfig)
+ s2.interaction.scrollToCellById('root[&]浙江[&]杭州-root[&]笔[&]price');
+ s2.interaction.scrollToCell(dataCell);
+ s2.interaction.scrollToTop();

Kapture 2024-03-07 at 17 28 43

🖼️ Screenshot

🔗 Related issue link

🔍 Self-Check before the merge

  • [ ] Add or update relevant docs.
  • [ ] Add or update relevant demos.
  • [ ] Add or update test case.
  • [ ] Add or update relevant TypeScript definitions.

lijinke666 avatar Mar 07 '24 09:03 lijinke666

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Aug 5, 2024 8:34am

vercel[bot] avatar Mar 07 '24 09:03 vercel[bot]

Size Change: +564 B (+0.17%)

Total Size: 327 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 229 kB +564 B (+0.25%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 69.9 kB
./packages/s2-react/dist/style.min.css 3.88 kB
./packages/s2-vue/dist/index.min.js 22 kB
./packages/s2-vue/dist/style.min.css 1.97 kB

compressed-size-action

github-actions[bot] avatar Mar 07 '24 09:03 github-actions[bot]

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

github-actions[bot] avatar Mar 08 '24 03:03 github-actions[bot]

Codecov Report

Attention: Patch coverage is 75.00000% with 31 lines in your changes missing coverage. Please review.

Project coverage is 80.75%. Comparing base (ecdc9c8) to head (1f19d4f). Report is 416 commits behind head on next.

Files Patch % Lines
packages/s2-core/src/interaction/root.ts 72.89% 8 Missing and 21 partials :warning:
packages/s2-core/src/cell/data-cell.ts 50.00% 1 Missing :warning:
packages/s2-core/src/facet/base-facet.ts 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2586      +/-   ##
==========================================
+ Coverage   75.77%   80.75%   +4.98%     
==========================================
  Files         257      180      -77     
  Lines       11994    10401    -1593     
  Branches     2464     2359     -105     
==========================================
- Hits         9088     8399     -689     
+ Misses       1398      555     -843     
+ Partials     1508     1447      -61     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 01 '24 08:08 codecov-commenter

:tada: This PR is included in version @antv/s2-v2.0.0-next.26 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

lijinke666 avatar Aug 09 '24 06:08 lijinke666

:tada: This PR is included in version @antv/s2-react-v2.0.0-next.25 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

lijinke666 avatar Aug 09 '24 06:08 lijinke666