S2 icon indicating copy to clipboard operation
S2 copied to clipboard

feat: 明细表-列分组增加 rowSpan 配置项, 用来支持自定义合并单元格 close #2150

Open wywppkd opened this issue 1 year ago • 6 comments

👀 PR includes

✨ Feature

  • [x] New feature

🎨 Enhance

  • [ ] Code style optimization
  • [ ] Refactoring
  • [ ] Change the UI
  • [ ] Improve the performance
  • [ ] Type optimization

🐛 Bugfix

  • [ ] Solve the issue and close #0

🔧 Chore

  • [ ] Test case
  • [ ] Docs / demos update
  • [ ] CI / workflow
  • [ ] Release version
  • [ ] Other ()

📝 Description

让明细表的列分组支持自定义合并单元格

🖼️ Screenshot

image

文档更新: image

Before After

🔗 Related issue link

close #2150

🔍 Self-Check before the merge

  • [x] Add or update relevant docs.
  • [ ] Add or update relevant demos.
  • [ ] Add or update test case.
  • [x] Add or update relevant TypeScript definitions.

wywppkd avatar Apr 08 '23 09:04 wywppkd

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 8:45am

vercel[bot] avatar Apr 08 '23 09:04 vercel[bot]

Codecov Report

Patch coverage: 76.03% and project coverage change: -0.06 :warning:

Comparison is base (1adc25d) 76.48% compared to head (2a22ccb) 76.43%.

:exclamation: Current head 2a22ccb differs from pull request most recent head d98268f. Consider uploading reports for the commit d98268f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2159      +/-   ##
==========================================
- Coverage   76.48%   76.43%   -0.06%     
==========================================
  Files         240      240              
  Lines       12312    12410      +98     
  Branches     2630     2659      +29     
==========================================
+ Hits         9417     9485      +68     
+ Misses       1377     1371       -6     
- Partials     1518     1554      +36     
Impacted Files Coverage Δ
packages/s2-core/src/cell/col-cell.ts 89.05% <ø> (-0.16%) :arrow_down:
packages/s2-core/src/cell/corner-cell.ts 83.16% <ø> (+0.47%) :arrow_up:
packages/s2-core/src/cell/table-col-cell.ts 86.53% <ø> (+4.72%) :arrow_up:
packages/s2-core/src/data-set/base-data-set.ts 94.11% <ø> (+0.56%) :arrow_up:
packages/s2-core/src/data-set/pivot-data-set.ts 72.39% <0.00%> (-0.73%) :arrow_down:
packages/s2-core/src/theme/index.ts 92.30% <ø> (-7.70%) :arrow_down:
packages/s2-core/src/cell/header-cell.ts 67.08% <50.00%> (-0.63%) :arrow_down:
packages/s2-core/src/utils/export/index.ts 72.36% <50.00%> (+0.12%) :arrow_up:
packages/s2-core/src/cell/data-cell.ts 73.96% <66.66%> (+0.15%) :arrow_up:
...ckages/s2-core/src/interaction/event-controller.ts 82.50% <66.66%> (+0.13%) :arrow_up:
... and 15 more

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 08 '23 10:04 codecov[bot]

你好 @wywppkd,感谢你的贡献, 为了让代码更健壮, 请补充相应单元测试, 如果有 API 改动, 请修改 相应的文档

Hello, @wywppkd, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.

github-actions[bot] avatar Apr 13 '23 05:04 github-actions[bot]

请增加一个相应的 demo 和对应的单测

lijinke666 avatar Apr 13 '23 05:04 lijinke666

请增加一个相应的 demo 和对应的单测

已经增加了示例 demo: http://localhost:8000/examples/basic/table#table-column-group-customize-cell

image

wywppkd avatar May 11 '23 11:05 wywppkd

请增加一个相应的 demo 和对应的单测

单测也加上了

wywppkd avatar May 18 '23 08:05 wywppkd