S2
S2 copied to clipboard
[WIP]feat: 趋势分析表支持配置图标条件
👀 PR includes
✨ Feature
- [x] New feature
🎨 Enhance
- [ ] Code style optimization
- [x] Refactoring
- [ ] Change the UI
- [ ] Improve the performance
- [ ] Type optimization
📝 Description
- 重构
drawObjectText
,将单元格按照指标矩阵划分包围盒,复用getTextAndFollowingIconPosition
方法,支持指标居左、居中、居右对齐。 *趋势分析表支持配置图标条件
TODO
- [ ] 单测
- [ ] 文档
- [ ] demo
- [ ] 指标间 padding 处理
🖼️ Screenshot
This pull request introduces 3 alerts and fixes 1 when merging 89ccb63c4097db3bf48fd6d7d2be652ef9793eba into ba88dec2c2ef9506264c64ba069685c0bd9a4c67 - view on LGTM.com
new alerts:
- 2 for Unused variable, import, function or class
- 1 for Useless assignment to local variable
fixed alerts:
- 1 for Useless assignment to local variable
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
antvis-s2 | ✅ Ready (Inspect) | Visit Preview | Sep 6, 2022 at 11:07PM (UTC) |
This pull request introduces 3 alerts and fixes 1 when merging 6f5c7ffd1e746c7b9cea977d3d0fa131966c79b0 into 2224320692d40447c76d0c678af6c6e60b1ca091 - view on LGTM.com
new alerts:
- 2 for Unused variable, import, function or class
- 1 for Useless assignment to local variable
fixed alerts:
- 1 for Useless assignment to local variable
Codecov Report
Merging #1684 (7a6dc3a) into master (2195f1a) will increase coverage by
0.07%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## master #1684 +/- ##
==========================================
+ Coverage 77.08% 77.16% +0.07%
==========================================
Files 234 234
Lines 11436 11453 +17
Branches 2421 2427 +6
==========================================
+ Hits 8816 8838 +22
+ Misses 1274 1265 -9
- Partials 1346 1350 +4
Impacted Files | Coverage Δ | |
---|---|---|
packages/s2-core/src/cell/data-cell.ts | 74.69% <ø> (ø) |
|
packages/s2-core/src/utils/text.ts | 40.95% <50.00%> (+7.27%) |
:arrow_up: |
...nteraction/brush-selection/base-brush-selection.ts | 70.41% <0.00%> (+0.37%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This pull request introduces 1 alert and fixes 1 when merging 554e7c91814abb194d39dcb5b7c18189b4ea6e57 into 2224320692d40447c76d0c678af6c6e60b1ca091 - view on LGTM.com
new alerts:
- 1 for Useless assignment to local variable
fixed alerts:
- 1 for Useless assignment to local variable
This pull request introduces 1 alert and fixes 1 when merging d0a15f88827dc143ed4db96f0f32b2c63ec79370 into 9aeb744f9eb1b7145894a12058d9ceb48602dc9f - view on LGTM.com
new alerts:
- 1 for Useless assignment to local variable
fixed alerts:
- 1 for Useless assignment to local variable
Size Change: +235 B (0%)
Total Size: 428 kB
Filename | Size | Change |
---|---|---|
./packages/s2-core/dist/index.min.js |
167 kB | +235 B (0%) |
ℹ️ View Unchanged
Filename | Size |
---|---|
./packages/s2-core/dist/style.min.css |
389 B |
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.cjs.js |
21.7 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.esm.js |
21.2 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js |
60.3 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.min.js |
33.9 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/config.js |
1.16 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/DOMElementFilter.js |
1.87 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/event-map.js |
1.18 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/events.js |
1.55 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/get-node-text.js |
300 B |
./packages/s2-core/node_modules/@testing-library/dom/dist/get-queries-for-element.js |
738 B |
./packages/s2-core/node_modules/@testing-library/dom/dist/get-user-code-frame.js |
810 B |
./packages/s2-core/node_modules/@testing-library/dom/dist/helpers.js |
1.07 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/index.js |
1.14 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/label-helpers.js |
1.05 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/matches.js |
1.14 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/pretty-dom.js |
1.47 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/all-utils.js |
337 B |
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/alt-text.js |
573 B |
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/display-value.js |
713 B |
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/index.js |
418 B |
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/label-text.js |
1.8 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/placeholder-text.js |
491 B |
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/role.js |
2.67 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/test-id.js |
498 B |
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/text.js |
958 B |
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/title.js |
718 B |
./packages/s2-core/node_modules/@testing-library/dom/dist/query-helpers.js |
1.81 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/role-helpers.js |
2.82 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/screen.js |
1.51 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/suggestions.js |
1.5 kB |
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for-element-to-be-removed.js |
748 B |
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for.js |
2.38 kB |
./packages/s2-react/dist/index.min.js |
64.2 kB |
./packages/s2-react/dist/style.min.css |
3.21 kB |
./packages/s2-vue/dist/index.min.js |
20.4 kB |
./packages/s2-vue/dist/style.min.css |
1.61 kB |
This pull request introduces 1 alert and fixes 1 when merging 168372bb55367ef890686420b251d4d156c67656 into 0a33c153b47044981f1d0fd63db8bac17af276ba - view on LGTM.com
new alerts:
- 1 for Useless assignment to local variable
fixed alerts:
- 1 for Useless assignment to local variable
This pull request introduces 1 alert and fixes 1 when merging f4c703fb2380b39247977e352b9c7d1971bb29cd into 46270ab0ae6e42cf92dcf77c0a35a70e07b9b10c - view on LGTM.com
new alerts:
- 1 for Useless assignment to local variable
fixed alerts:
- 1 for Useless assignment to local variable
This pull request introduces 1 alert and fixes 1 when merging 7a6dc3aabb7e1bba4b37927ff1317588c614b53a into 2195f1aec681085ec32ee1446b780e00af901c47 - view on LGTM.com
new alerts:
- 1 for Useless assignment to local variable
fixed alerts:
- 1 for Useless assignment to local variable
:tada: This PR is included in version @antv/s2-v1.29.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
:tada: This PR is included in version @antv/s2-react-v1.26.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: