S2 icon indicating copy to clipboard operation
S2 copied to clipboard

feat: 初版编辑表

Open serializedowen opened this issue 2 years ago • 4 comments

👀 PR includes

✨ Feature 编辑表

  • [x] New feature

🐛 Bugfix

  • [x] Solve the issue and close #0

🔧 Chore

  • [ ] Test case
  • [x] Docs / demos update playground中新增编辑表模式
  • [ ] CI / workflow
  • [ ] Release version

📝 Description

编辑组件透出,2种形式:

  1. 直接使用<EditableTable /> react组件
  2. 在TableSheet组件下使用<EditCell />组件

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • [ ] Add or update relevant docs.
  • [ ] Add or update relevant demos.
  • [ ] Add or update test case.
  • [ ] Add or update relevant TypeScript definitions.

serializedowen avatar Aug 02 '22 03:08 serializedowen

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
antvis-s2 ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 8:10AM (UTC)
s2 ❌ Failed (Inspect) Sep 22, 2022 at 8:10AM (UTC)

vercel[bot] avatar Aug 02 '22 03:08 vercel[bot]

Size Change: +1.5 kB (0%)

Total Size: 430 kB

Filename Size Change
./packages/s2-react/dist/index.min.js 65.8 kB +1.46 kB (+2%)
./packages/s2-react/dist/style.min.css 3.32 kB +36 B (+1%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/index.min.js 168 kB
./packages/s2-core/dist/style.min.css 389 B
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.cjs.js 21.7 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.esm.js 21.2 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js 60.3 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.min.js 33.9 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/config.js 1.16 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/DOMElementFilter.js 1.87 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/event-map.js 1.18 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/events.js 1.55 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/get-node-text.js 300 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-queries-for-element.js 738 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-user-code-frame.js 810 B
./packages/s2-core/node_modules/@testing-library/dom/dist/helpers.js 1.07 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/index.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/label-helpers.js 1.05 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/matches.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/pretty-dom.js 1.47 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/all-utils.js 337 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/alt-text.js 573 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/display-value.js 713 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/index.js 418 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/label-text.js 1.8 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/placeholder-text.js 491 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/role.js 2.67 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/test-id.js 498 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/text.js 958 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/title.js 718 B
./packages/s2-core/node_modules/@testing-library/dom/dist/query-helpers.js 1.81 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/role-helpers.js 2.82 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/screen.js 1.51 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/suggestions.js 1.5 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for-element-to-be-removed.js 748 B
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for.js 2.38 kB
./packages/s2-vue/dist/index.min.js 20.4 kB
./packages/s2-vue/dist/style.min.css 1.68 kB

compressed-size-action

github-actions[bot] avatar Aug 02 '22 03:08 github-actions[bot]

你好, @serializedowen CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @serializedowen CI run failed, please click the [Details] button for detailed log information and fix it.

github-actions[bot] avatar Aug 02 '22 03:08 github-actions[bot]

Codecov Report

Base: 77.16% // Head: 76.62% // Decreases project coverage by -0.54% :warning:

Coverage data is based on head (7a5416a) compared to base (a4b14a8). Patch coverage: 40.41% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1629      +/-   ##
==========================================
- Coverage   77.16%   76.62%   -0.55%     
==========================================
  Files         234      238       +4     
  Lines       11518    11687     +169     
  Branches     2449     2487      +38     
==========================================
+ Hits         8888     8955      +67     
- Misses       1258     1337      +79     
- Partials     1372     1395      +23     
Impacted Files Coverage Δ
packages/s2-shared/src/utils/drill-down.ts 21.31% <ø> (ø)
...mponents/sheets/editable-sheet/edit-cell/index.tsx 31.88% <31.88%> (ø)
packages/s2-react/src/utils/invokeComponent.tsx 35.55% <32.55%> (ø)
...act/src/components/sheets/editable-sheet/index.tsx 50.00% <45.45%> (ø)
...2-react/src/components/sheets/base-sheet/index.tsx 77.27% <68.75%> (+4.85%) :arrow_up:
packages/s2-react/src/components/sheets/index.tsx 72.50% <100.00%> (+1.44%) :arrow_up:
packages/s2-react/src/utils/SpreadSheetContext.tsx 85.00% <100.00%> (ø)
packages/s2-core/src/facet/base-facet.ts 81.32% <0.00%> (-2.97%) :arrow_down:
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 02 '22 03:08 codecov[bot]

This pull request introduces 1 alert when merging b707f2e82c4dc2d693ada9727ba81183e0f11a68 into 46270ab0ae6e42cf92dcf77c0a35a70e07b9b10c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 05 '22 03:09 lgtm-com[bot]

This pull request introduces 1 alert when merging 6474569db8d74459696d2243e9be59ff5ae99399 into 46270ab0ae6e42cf92dcf77c0a35a70e07b9b10c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 05 '22 03:09 lgtm-com[bot]

This pull request introduces 1 alert when merging 80d6f92ac1d2ebb076f50e06c68c2b9ca029ec46 into 46270ab0ae6e42cf92dcf77c0a35a70e07b9b10c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 05 '22 03:09 lgtm-com[bot]

This pull request introduces 1 alert when merging 231f9f369d7f9847c1a7cf810451e40e569b50c9 into baa72454702f34ccd9dc5957e8574b8e38087c62 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 05 '22 06:09 lgtm-com[bot]

This pull request introduces 1 alert when merging 6e9a033b5c2f5ebc8a280aa4db18006e80220efd into baa72454702f34ccd9dc5957e8574b8e38087c62 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 05 '22 06:09 lgtm-com[bot]

This pull request introduces 1 alert when merging 2170635e26dc9ce5c6e1829bff1d83d921a7669c into 67e09c43b6508cbd141dc47fedbebfbc247cbb3f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 19 '22 08:09 lgtm-com[bot]

This pull request introduces 1 alert when merging 5f156e841ed44d1b112b095a7682d0c4359c3e26 into 67e09c43b6508cbd141dc47fedbebfbc247cbb3f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 19 '22 08:09 lgtm-com[bot]

This pull request introduces 1 alert when merging 7a5416a2767ab0b479c79a902faf0a15f1912f27 into 2a80862e488644efc1e122eecfa773104e4dcd1e - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Sep 22 '22 08:09 lgtm-com[bot]

:tada: This PR is included in version @antv/s2-react-v1.28.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

lijinke666 avatar Oct 02 '22 09:10 lijinke666

请问这个 PR 相关的文档可以在哪里看,官网上找了一圈没有找到

Nayacco avatar Oct 02 '22 18:10 Nayacco

请问这个 PR 相关的文档可以在哪里看,官网上找了一圈没有找到

@GoldSubmarine 编辑表还有一些细节需要打磨, 文档还有待更新 cc @serializedowen

lijinke666 avatar Oct 09 '22 10:10 lijinke666

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

lijinke666 avatar Nov 25 '22 07:11 lijinke666