Fix infographic text overlap
I saw the title and description overlap on first render. Root cause: text boxes are measured before fonts finish loading; if measurement and final render use different fonts (or fonts load after mount), sizes are wrong. The skill should generate HTML that renders reliably across browsers/system fonts without overlaps.
Examples before the fix:
after the fix:
Summary of Changes
Hello @nemo9cby, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a visual bug in infographics where text elements would overlap. The root cause was identified as text box measurements occurring before custom fonts had fully loaded, leading to incorrect sizing. The solution involves re-rendering the infographic once all document fonts are confirmed to be ready, thereby ensuring that text is correctly positioned and displayed without overlap.
Highlights
- Infographic Text Overlap Fix: Resolved an issue where infographic titles and descriptions would overlap on initial render due to text boxes being measured before fonts were fully loaded.
- Font Loading Dependency: Implemented a re-render mechanism for infographics that triggers after all document fonts have finished loading, ensuring accurate text placement and preventing layout inconsistencies.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.