G6 icon indicating copy to clipboard operation
G6 copied to clipboard

fix: Fix Tree Layout Expand

Open lyw405 opened this issue 4 months ago • 3 comments

📋 关联 Issue

  • Closes #7447 - 点击三级节点展开时位置错乱
  • Closes #7439 - 默认收拢的流程图无法在画布右侧展开
  • Closes #7325 - 三级数据打开位置错乱,收起时节点间距未调整
  • Closes #7283 - Indented 布局展开子节点后异常

lyw405 avatar Oct 28 '25 08:10 lyw405

Summary of Changes

Hello @lyw405, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a comprehensive solution to several reported bugs concerning tree layout expansion and collapse. The core changes involve refactoring the ElementController and LayoutController to introduce a more robust and animated handling of tree structures. This includes caching layout simulation results, applying calculated offsets to maintain node positions, and orchestrating animations for a smoother user experience when interacting with tree-based graphs.

Highlights

  • Tree Layout Expansion Fixes: Addresses multiple issues where expanding or collapsing nodes in tree layouts resulted in incorrect positioning, visual glitches, or unadjusted spacing.
  • Enhanced Animation Control: Introduces a refined animation mechanism for tree layouts, ensuring smooth transitions and correct element placement during expand/collapse operations.
  • Layout Simulation Caching: Implements caching for layout simulation results to prevent redundant calculations, improving performance during interactive layout changes.
  • Offset Calculation for Stability: Adds logic to calculate and apply layout offsets, maintaining the visual stability of the graph by preventing view shifts when nodes are expanded or collapsed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Oct 28 '25 08:10 gemini-code-assist[bot]

嗨,请问这个有合并上线预期时间吗?

lihawhaw avatar Nov 20 '25 07:11 lihawhaw

/gemini review

Aarebecca avatar Nov 27 '25 03:11 Aarebecca