Sergei Demchenko

It is hard to test these classes. Replace class methods with instance methods. Consider merging these 2 classes into one class.

Revise the code and remove "goto" operators.

Currently we support only Microsoft's authorities (AAD, ADFS, B2C). Decide if we should allow to provide 3d party authorities.

Move out drs discovery endpoint from here, because it's ADFS and not AAD specific. Endpoint providing should apply also to basic Oauth2 flow, not only to AAD (e.g. we should...

Decide if we need to move out logic that is not related to json parsing from this class. In particular, these methods: ``` @property (readonly) MSIDWebviewFactory *webviewFactory; - (NSString *)cacheEnvironmentFromEnvironment:(NSString...

Currently we compare items like this: result &= (!l && !r) || [l isEqualToString:r]; Change it to something like this: result &= (l == r) || [l isEqualToString:r]; It will...

See how it is done in MSIDOpenIdConfigurationInfoRequest: ``` - (instancetype _Nullable)initWithEndpoint:(nonnull NSURL *)endpoint context:(nullable id)context NS_DESIGNATED_INITIALIZER; ```

Instead of passing authority as NSURL, developer should create instance of MSIDAuthority and provide authority endpoint together with authority type to it.

Consider the following flow: We get list of ATs, using api like 'getAllTokensOfType:withClientId:context:error', after we set expireOn to current date and we wanna save tokens back to the cache.